'Toggle High Contrast Theme' toggles only the monaco theme, not the IDE theme

[kittaakos]

Bug Description:

screencast.2021-02-03.18-08-04.mp4

I would expect it to toggle the IDE theme, not just monaco.

Ref: https://github.com/microsoft/vscode/blob/59cf8810d92ac7c7f41103815c20934ab748b7a2/src/vs/editor/standalone/browser/toggleHighContrast/toggleHighContrast.ts#L25-L35

Steps to Reproduce:

Additional Information

• Operating System:
• Theia Version:

[kittaakos]

I am not sure if it is a bug at all or what is the intention of this command. Although the current UX is odd in Theia, the editor action does toggle the theme via the IStandaloneThemeService. So it's monaco only. Maybe, we could listen on the theme changes and toggle the IDE theme also.

[vince-fugnitto]

The Toggle High Contrast Theme is contributed by the monaco editor (verified with the playground), but I do not see the command available in VS Code. If we are to keep it, I think we should do like you said and apply the theme to the whole application if we see the editor theme has been updated through a theme change event.

[kittaakos]

is contributed by the monaco editor (verified with the playground), but I do not see the command available in VS Code.

:) I did the same. I do not know what is the purpose of this command or why it is not available in VS Code.

If we are to keep it, I think we should do like you said and apply the theme to the whole application if we see the editor theme has been updated through a theme change event.

OK. It makes sense, let's adjust Theia's theme on the change. I do not see a good reason for starting to filter monaco.EditorAction-based commands in Theia.