Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Previous active tab flicker when navigating the top menu, Navigation sometimes disabled when Webview was last focused #8572

Open
EstherPerelman opened this issue Sep 29, 2020 · 1 comment
Labels
help wanted issues meant to be picked up, require help menus issues related to the menu ui/ux issues related to user interface / user experience webviews issues related to webviews

Comments

@EstherPerelman
Copy link
Contributor

EstherPerelman commented Sep 29, 2020

When focusing a tab inside the main panel and then - navigating between the tabs in the top panel -
The focused tab inside the main panel flicker,
Before menu closes - the previous-focused-tab getting focus even though the user is still on the menu bar -
When navigating by keyboard arrows and the previous-focused-tab was a Webview - sometimes the focus not return back to the menu (because focusing on the webview iframe) so navigation is disabled.

Bug Description:

Steps to Reproduce:

For the flicker issue:

  1. Focus on a file
  2. Click on any tab inside the top menu
  3. Navigate between the menu tabs (by mouse/ keyboard)

For the IFrame issue:

  1. Open a webview
  2. Click on any tab in the top menu
  3. Navigate between the menu tabs by keyboard

This is how it flicker:
menu

It happens because there's code for restoring the focus before the menu closes, When navigating on menu - the tab first closes - so previous-focused-tab inside main panel is focused and only then - the next selected tab is opened...

Additional Information

  • Operating System: Windows
  • Theia Version: Master
@vince-fugnitto vince-fugnitto added help wanted issues meant to be picked up, require help menus issues related to the menu ui/ux issues related to user interface / user experience labels Sep 29, 2020
@EstherPerelman EstherPerelman changed the title Previous active tab flicker when navigating the top menu Previous active tab flicker when navigating the top menu, Navigation sometimes disabled when Webview was last focused Sep 30, 2020
EstherPerelman added a commit to EstherPerelman/theia that referenced this issue Oct 1, 2020
…ng the top menu

Signed-off-by: Esther Perelman <esther.perelman@sap.com>
EstherPerelman added a commit to EstherPerelman/theia that referenced this issue Oct 1, 2020
…ng the top menu

Signed-off-by: Esther Perelman <esther.perelman@sap.com>

fixed bug focus
EstherPerelman added a commit to EstherPerelman/theia that referenced this issue Oct 1, 2020
…ng the top menu

Signed-off-by: Esther Perelman <esther.perelman@sap.com>
@vince-fugnitto vince-fugnitto added the webviews issues related to webviews label Oct 26, 2020
@vince-fugnitto
Copy link
Member

In addition, there is also flickering with contributed toolbar items which give a poor user-experience:

webview

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
help wanted issues meant to be picked up, require help menus issues related to the menu ui/ux issues related to user interface / user experience webviews issues related to webviews
Projects
None yet
2 participants