-
Notifications
You must be signed in to change notification settings - Fork 2.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
There is no document for breakpointinput:vs.editor.ICodeEditor%3A1 #7671
Comments
hello I also encountered the same problem, how can I solve it? |
@jili544 thank you for the response, do you mind providing details on how you reproduced the issue (steps)? |
To reproduce, open any file (for example, a package.json) while the debug view is open. |
Or even when the debug view isn't open. I seem to get it opening any source code file at all. Closing the debug view entirely doesn't stop the error. I hadn't seen this previously, but in the last 3-4 weeks (at least), it's been pretty constant. |
To reproduce this problem, follow the steps below.
|
I don't know if I found the root cause. Probably when create the async createInline(uri: URI, node: HTMLElement, options?: MonacoEditor.IOptions): Promise<MonacoEditor> {
return this.doCreateEditor(uri, async (override, toDispose) => {
const overrides = override ? Array.from(override) : [];
overrides.push([IContextMenuService, { showContextMenu: () => {/** no op! */ } }]);
const document = new MonacoEditorModel({
uri,
readContents: async () => '',
dispose: () => { }
}, this.m2p, this.p2m);
toDispose.push(document);
// =======================================================
// probably we should emit a event to notify a model added
// =======================================================
const model = (await document.load()).textEditorModel;
return new MonacoEditor(
uri,
document,
node,
this.services,
Object.assign({
model,
isSimpleWidget: true,
autoSizing: false,
minHeight: 1,
maxHeight: 1
}, MonacoEditorProvider.inlineOptions, options),
overrides
);
});
} |
Hi,
Any updates on this issue? |
I believe I now understand the source of the issue. As part of the lifecycle of various widgets, we create Monaco editors for specific purposes (breakpoint log entry input and output), but we either don't register those with the document store available to extensions or their URI's get mangled and aren't accessible under the stringified name used by plugins. As a consequence, when the editor makes requests (for code lenses, for example) that would normally be served by plugins, the plugins find that they can't service the request, and errors are logged. I will do some further investigation and then work to ensure that editors that should not make these requests don't make them. |
@colin-grant-work did you ever make progress on this? Does anyone know of a workaround? I also started to see this error after switching from I just noticed that open-vsx.org is down, I wonder if that could be related. |
@danepowell the error itself should be pretty harmless and there is no workaround at the moment for it. You could investigate if you'd like to find a solution, the latest was to determine which editors might be making these requests when they shouldn't (ex: debug console) (#7671 (comment)).
The error is unrelated to the status of open-vsx. |
It seems we provide documents for inline editors like breakpoint expressions editor to the plugin host process. Not sure we should do it.
The text was updated successfully, but these errors were encountered: