ctrl+f defaults to the browser search

[akosyakov]

Description

Reproduction Steps

• open SIW view
• press ctrl+f to retrigger search
• native browser search is shown
• search is not retriggered

OS and Theia version:

Diagnostics:

[kittaakos]

• native browser search is shown

FYI: previously we throw an exception: #7474

[kittaakos]

Related conversation: #7481 (comment)

[kittaakos]

Linked issue: #7346

[akosyakov]

@kittaakos you are right about #7346

I'm still not sure about falling back to the native search.

[kittaakos]

We have to re-introduce a NOOP core.find then.

[akosyakov]

What about core.replace? We used to prevent it as well.

[kittaakos]

What about core.replace?

Yes. Obviously, it belongs here.

We used to prevent it as well.

"prevent" 😄 yes.

---

I think Select All, Find, and Replace should be generalized all over the application; the active widget should handle it if it can, otherwise we have to fall-back to the default NOOP. Most likely that's a bigger task.

[akosyakov]

I think Select All, Find, and Replace should be generalized all over the application; the active widget should handle it if it can, otherwise we have to fall-back to the default NOOP

Strangely the same issue present in VS Code, try with the terminal for instance:

• if you use a find keybinding then it shows find widget in the terminal
• but if you use Edit -> Find it does nothing.

I don't think that's nice though.