-
Notifications
You must be signed in to change notification settings - Fork 2.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[editor] deleting a file should be reflected in the corresponding editor #13525
Comments
@zoswing I believe we employ the same UX here as vscode. What would be the expected behavior for you? |
Thank you for your response. I would like the behavior of Theia to be consistent with VS Code. In VS Code, when I delete a file, the opened files in the editor are closed instead of having a 'deleted' label. Is the interaction design of Theia intentionally different from VS Code? |
Ah, I misremembered. vscode keeps the editor open if the file was deleted on the file system, but not through a user action in the navigator. If you delete it through the navigator, the editor closes. Could you please edit the original post to explain in more detail what the expected behavior is? The original post is very light on information and one could argue that adding |
Okay, I have made the necessary improvements to the original post. Additionally, I would like to kindly inquire if Theia has any plans to align its interactions with VS Code regarding the issue mentioned in the post? |
We have a roadmap item to try to stay up to date with the vscode API (see #13445 for example), but nothing beyond that. I've added the appropriate label that indicates that anyone is free to pick up the issue. If you're interested in seeing this fixed, your best bet is to provide a pull request. We try to review all PRs in a timely manner. Alternatively, the project has a few commercial partners that can help you with this as well. |
got it, thanks~ |
When a file is opened in the editor, if it is deleted using the right-click menu in the navigation tree, the file remains open in the editor but is marked as 'deleted'. However, if you press Ctrl + S to save, the deleted file is restored.
In contrast, in VS Code, when a file is deleted from the navigation tree, the opened files in the editor are also closed.
I would like Theia to behave consistently with VS Code in this aspect.
The text was updated successfully, but these errors were encountered: