You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Windows and macOS have failed: Windows has an issue with the way THEIA_CONFIG_DIR is set in playwright package.json. On Mac, there's a failure in theia-text-editor.test.ts, but the new tests have passed. So, I think this PR does not make things worse - if we want to run these tests on the other OS, there will be a bit of work, not directly related to this contribution.
Here's how to quickly modify the Playwright workflow so it runs on all OS, when pushed on a branch (adjust the branch name, from "playwright-add-terminal", so it matches your test branch):
The text was updated successfully, but these errors were encountered:
https://github.com/marcdumais-work/theia/actions/runs/4679291140
Windows and macOS have failed: Windows has an issue with the way THEIA_CONFIG_DIR is set in playwright package.json. On Mac, there's a failure in
theia-text-editor.test.ts
, but the new tests have passed. So, I think this PR does not make things worse - if we want to run these tests on the other OS, there will be a bit of work, not directly related to this contribution.Originally posted by @marcdumais-work in #12381 (comment)
Failure on Windows:
Failures on macOS (1/2 passed during retry):
Here's how to quickly modify the Playwright workflow so it runs on all OS, when pushed on a branch (adjust the branch name, from "playwright-add-terminal", so it matches your test branch):
The text was updated successfully, but these errors were encountered: