chore: add cross-env dependency to examples/playwright #13634
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What it does
This adds cross-env as dev dependency and adjusts the scripts in examples/playwright accordingly. This is a way to enable running the playwright tests on Windows machines.
Contributed on behalf of STMicroelectronics
How to test
cd examples/playwright; yarn; yarn build
yarn ui-tests
Follow-ups
We checked the status of the cross-env package and found that it is in maintenance mode. The authors of cross-env consider the development finished and fix only severe bugs and keep it up-to-date along with nodejs. The most recent commit in cross-env is 4 years old.
Please consider this and the implied additional threats regarding supply chain attacks that adding cross-env as a dev dependency might introduce into Theia when reviewing this PR.
Review checklist
Reminder for reviewers