[tree] RETURN should not expand nodes

[JanKoehnlein]

RETURN should not expand a node, at least if they are openable.
This yields to strange behavior in the call hierarchy: When you hit RETURN on a node, the respective call gets highlighted in the editor, the editor grabs the focus and the node is expanded. The latter feels odd. To expand a node using the keyboard you can still use left-arrow.

[epatpol]

@JanKoehnlein This seems to work now no? Should we close it?

[JanKoehnlein]

@epatpol it has been locally fixed for call hierarchy, but not for trees in general, e.g. the navigator.

[vince-fugnitto]

I believe this issue should be closed.
We have the same behavior as VSCode, tree nodes can be collapsed/expanded using ENTER

[JanKoehnlein]

Checking with VSCode again, in the explorer RETURN on a node triggers rename and doesn't expand.

[vince-fugnitto]

I tested against the latest vscode (I also don't have any custom keybindings):

[JanKoehnlein]

Also latest VSCode, but on a MacBook, German keyboard. There is no additional ENTER key as on Windows, just RETURN: RETURN triggers rename.

[vince-fugnitto]

@JanKoehnlein I initially tested on Linux. I re-tested using Mac and I see that ENTER triggers a rename in the navigator. The fix then is thus likely to be OS-dependent.

[vrubezhny]

@JanKoehnlein Does it mean that we have wrong behaviour in Class Hierarchy and Type Hierarchy Dialogs then?