[preferences] Reject invalid preference schemas.

Fixes #6106 Signed-off-by: Alex Tugarev <alex.tugarev@typefox.io>
eclipse-theia · Sep 5, 2019 · 62328bf · 62328bf
1 parent 78e0b20
commit 62328bf
Showing 1 changed file with 7 additions and 0 deletions.
diff --git a/packages/core/src/browser/preferences/preference-contribution.ts b/packages/core/src/browser/preferences/preference-contribution.ts
@@ -135,6 +135,13 @@ export class PreferenceSchemaProvider extends PreferenceProvider {
     }
 
     protected doSetSchema(schema: PreferenceSchema): PreferenceProviderDataChange[] {
+        const ajv = new Ajv();
+        const valid = ajv.validateSchema(schema);
+        if (!valid) {
+            const errors = !!ajv.errors ? ajv.errorsText(ajv.errors) : 'unknown validation error';
+            console.error('An invalid preference schema was rejected: ' + errors);
+            return [];
+        }
         const scope = PreferenceScope.Default;
         const domain = this.getDomain();
         const changes: PreferenceProviderDataChange[] = [];