Skip to content

Commit

Permalink
Fix symlinks should be resolved when initializing plugins (#12841)
Browse files Browse the repository at this point in the history
- Added symlink resolution to HostedPluginReader
  • Loading branch information
vatsal-uppal-1997 authored Oct 2, 2023
1 parent ab4627e commit 525b3b1
Showing 1 changed file with 4 additions and 2 deletions.
6 changes: 4 additions & 2 deletions packages/plugin-ext/src/hosted/node/plugin-reader.ts
Original file line number Diff line number Diff line change
Expand Up @@ -17,6 +17,7 @@
import * as path from 'path';
import * as express from '@theia/core/shared/express';
import * as escape_html from 'escape-html';
import { realpath } from 'fs/promises';
import { ILogger } from '@theia/core';
import { inject, injectable, optional, multiInject } from '@theia/core/shared/inversify';
import { BackendApplicationContribution } from '@theia/core/lib/node/backend-application';
Expand Down Expand Up @@ -93,11 +94,12 @@ export class HostedPluginReader implements BackendApplicationContribution {
if (!pluginPath) {
return undefined;
}
const manifest = await loadManifest(pluginPath);
const resolvedPluginPath = await realpath(pluginPath);
const manifest = await loadManifest(resolvedPluginPath);
if (!manifest) {
return undefined;
}
manifest.packagePath = pluginPath;
manifest.packagePath = resolvedPluginPath;
return manifest;
}

Expand Down

0 comments on commit 525b3b1

Please sign in to comment.