Repository navigation
Extract IMouseListener - #583
Open
Wagner-Laranjeiras wants to merge 1 commit into
Open
Wagner-Laranjeiras wants to merge 1 commit into
Wagner-Laranjeiras wants to merge 1 commit into
Conversation
Reuse TYPES.MouseListener so existing bindings keep working and a second token cannot double-dispatch. Signed-off-by: Wagner Laranjeiras <wagner.laranjeiras@typefox.io>
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Extract
IMouseListenersoMouseToolis not tied to the convenience classWhat
IMouseListenerinterface covering all mouse handlers plusdecorate.MouseListenernow implements it.MouseToolandPopupMouseToolnow acceptIMouseListener[]instead ofMouseListener[], including inregister/deregister.TYPES.MouseListenertoken, so current bindings keep working and a second token can't cause double dispatch..reduce((a, b) => a.concat(b))threw aTypeErrorwhen no mouse listeners were registered. It now has an initial[].Why
MouseTooldepended on the concreteMouseListenerclass. Listeners could not be written without extending it, and the tool is now consistent with the existingITouchListenerapproach.Compatibility
Non-breaking.
MouseListeneris unchanged in behaviour and still implements all handlers. Existing subclasses and bindings work as before.Testing
mouse-tool.spec.tsbuilds real Inversify containers. It covers:IMouseListenerimplementations that don't extendMouseListenernpm run build,npm run lint(0 errors) andnpm test(364 tests) pass.Closes #478