Repository navigation
Conversation
- Import file-saver through its CommonJS default so Node can load sprotty. - Upgrade autocompleter to v10 and call its ESM default directly. Also: - Expose built deep paths from sprotty-protocol and sprotty-library.
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
file-saver is CommonJS, Node cannot detect its saveAs named export in the minified bundle, causing import('sprotty') to fail. Use its default import instead.
Autocompleter 9 resolves differently in Node and bundlers, so the hard-coded .default breaks the bundled command palette. Upgrade to v10’s ESM entry and call the default import directly.
(see also https://nodejs.org/api/esm.html#interoperability-with-commonjs)
Export of deep paths "./lib" was inconsistent between packages. sprotty and sprotty-elk have it.
sprotty-protocol and sprotty-library don't. Aligned so that all packages export the ./lib/* path,.
Note: This issues were identified during a test/poc upgrade of GLSP to the latest sprotty main.
Apart from these minor issues everything else wen't as expected.