Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allows scrolling the viewport using alt + wheel #340

Merged
merged 1 commit into from
Feb 14, 2023
Merged

Allows scrolling the viewport using alt + wheel #340

merged 1 commit into from
Feb 14, 2023

Conversation

dhuebner
Copy link
Contributor

@dhuebner dhuebner commented Feb 9, 2023

To try it out open the SVG example, hold alt and use mouse wheel or touchpad to scroll.

See #339

spoenemann
spoenemann reviewed Feb 10, 2023
View reviewed changes
Copy link
Contributor

@spoenemann spoenemann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Error:

src/features/viewport/zoom.ts(18,1): error TS6133: 'Viewport' is declared but its value is never read.

packages/sprotty/src/features/viewport/zoom.ts Outdated Show resolved Hide resolved
@dhuebner
Scroll viewport with wheel + Alt #302
b0bb16a 
Scroll the viewport using alt+wheel #339
spoenemann
spoenemann approved these changes Feb 14, 2023
View reviewed changes
Copy link
Contributor

@spoenemann spoenemann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great improvement!

@dhuebner dhuebner merged commit b7cd8f7 into master Feb 14, 2023
@dhuebner dhuebner deleted the dh/viewport-scroll-302 branch February 14, 2023 10:53
@tortmayr tortmayr added this to the v0.14.0 milestone Aug 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@spoenemann spoenemann spoenemann approved these changes

@tortmayr tortmayr Awaiting requested review from tortmayr

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v0.14.0
Development

Successfully merging this pull request may close these issues.
3 participants
@dhuebner @spoenemann @tortmayr