Merged
Conversation
gfontorbe
had a problem deploying
to
pull-request-preview
GitHub Actions
Failure
spoenemann
reviewed
Oct 30, 2025
| // Configure for client-side layout | ||
| configureViewerOptions(context, { | ||
| needsClientLayout: true, // Enable client layout computation | ||
| needsServerLayout: false, // Disable server layout |
Contributor
There was a problem hiding this comment.
Ok the root of the problem is this config option, which is almost 8 years old 😅
What shall we do? We could still call it server layout to be consistent with this option, but explain that the layout engine can also run in the frontend?
Contributor
Author
There was a problem hiding this comment.
I went with changing client/server to micro/macro.
For the options naming... that's how it is I guess
Contributor
There was a problem hiding this comment.
If we want to rename it, we could mark these two options deprecated and introduce new properties. Don't know if it's worth the effort though.
gfontorbe
had a problem deploying
to
pull-request-preview
GitHub Actions
Failure
spoenemann
approved these changes
Nov 17, 2025
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Documenttion about client/server layout strategies