-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
First draft sprotty-elk documentation #35
Conversation
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
All in all very nice.
Added some suggestions
|
||
## Preprocessing | ||
|
||
Once the SModel has been transformed into an ELK graph, we can apply some preprocessing to the graph. This is done by implementing a class implementing the `ILayoutPreprocessor` interface, and passing it to the constructor of the `ElkLayoutEngine`. The preprocessor class needs to implement a `preprocess` method, which will receive the ELK graph, the Sprotty graph, and the index. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
isn't the info here and in the postprocessing section missing on what symbol to bind these processors?
Or maybe this could be shown in the Bind the LayoutConfigurator to the ContainerModule
with an optional comment behind the binding
Signed-off-by: Guillaume Fontorbe <guillaume.fontorbe@typefox.io>
e8c056d
to
586c255
Compare
Signed-off-by: Guillaume Fontorbe <guillaume.fontorbe@typefox.io>
First draft for the documentation about sprotty-elk