Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Styling documentation #34

Merged
merged 2 commits into from
Feb 22, 2024
Merged

Styling documentation #34

merged 2 commits into from
Feb 22, 2024

Conversation

gfontorbe
Copy link
Contributor

First draft of the documentation regarding styling the diagram with CSS

@gfontorbe gfontorbe temporarily deployed to pull-request-preview February 8, 2024 09:50 — with GitHub Actions Inactive
Copy link

github-actions bot commented Feb 8, 2024

PR Preview Action v1.4.6
Preview removed because the pull request was closed.
2024-02-22 09:48 UTC

Copy link
Contributor

@jonah-iden jonah-iden left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great documentation. Reads very nicely.
See the one suggestion below


## Styling on User Interaction

Taking advantage of the conditional CSS classes, you can also apply styles to your diagram elements based on user interaction. For example, you could apply a CSS class to a node when it is selected. Without going into the details of how to handle user interaction, let's look at how Sprotty's default views handle this.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe add a reference here to the user interaction documentation

Signed-off-by: Guillaume Fontorbe <guillaume.fontorbe@typefox.io>
@gfontorbe gfontorbe force-pushed the gfontorbe/styling-documentation branch from a400aa3 to efd80c2 Compare February 22, 2024 09:40
Signed-off-by: Guillaume Fontorbe <guillaume.fontorbe@typefox.io>
@gfontorbe gfontorbe merged commit 04f357a into main Feb 22, 2024
4 checks passed
@gfontorbe gfontorbe deleted the gfontorbe/styling-documentation branch February 22, 2024 09:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants