Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added documentation about EdgePlacement to SLabelImpl #31

Merged
merged 2 commits into from
Jan 12, 2024

Conversation

jbicker
Copy link
Contributor

@jbicker jbicker commented Jan 9, 2024

As described in the title.

@jbicker jbicker temporarily deployed to pull-request-preview January 9, 2024 17:21 — with GitHub Actions Inactive
Copy link

github-actions bot commented Jan 9, 2024

PR Preview Action v1.4.6
Preview removed because the pull request was closed.
2024-01-12 10:46 UTC

Copy link
Contributor

@gfontorbe gfontorbe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, just a couple minor comments about the wording

hugo/content/docs/smodel.md Outdated Show resolved Hide resolved
Co-authored-by: Guillaume Fontorbe <guillaume.fontorbe@typefox.io>
Copy link
Contributor

@gfontorbe gfontorbe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@gfontorbe gfontorbe merged commit c32088b into eclipse-sprotty:main Jan 12, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants