Skip to content

process: verification guide for types and methods #721

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
pahmann merged 11 commits into from
Apr 10, 2025
Merged

process: verification guide for types and methods #721

pahmann merged 11 commits into from
Apr 10, 2025

Conversation

@pahmann
Copy link
Member

@pahmann pahmann commented Mar 18, 2025

As part of the interim audit, it was mentioned to better explain the testing methods and derivation techniques.

see #497

@github-actions
Copy link

github-actions bot commented Mar 18, 2025 •
edited
Loading

License Check Results

🚀 The license check job ran with the Bazel command:

bazel run //:license-check

Status: ✅ Passed

Click to expand output 
[License Check Output]
2025/04/10 11:36:41 Downloading https://releases.bazel.build/7.4.0/release/bazel-7.4.0-linux-x86_64...
Extracting Bazel installation...
Starting local Bazel server and connecting to it...
Computing main repo mapping: 
Computing main repo mapping: 
Computing main repo mapping: 
Loading: 
Loading: 0 packages loaded
Loading: 0 packages loaded
    currently loading: 
Analyzing: target //:license-check (1 packages loaded, 0 targets configured)
Analyzing: target //:license-check (1 packages loaded, 0 targets configured)

Analyzing: target //:license-check (90 packages loaded, 10 targets configured)

Analyzing: target //:license-check (99 packages loaded, 10 targets configured)

Analyzing: target //:license-check (131 packages loaded, 1596 targets configured)

Analyzing: target //:license-check (134 packages loaded, 1630 targets configured)

Analyzing: target //:license-check (145 packages loaded, 2465 targets configured)

Analyzing: target //:license-check (145 packages loaded, 2465 targets configured)

Analyzing: target //:license-check (148 packages loaded, 4487 targets configured)

Analyzing: target //:license-check (149 packages loaded, 4611 targets configured)

INFO: Analyzed target //:license-check (150 packages loaded, 4737 targets configured).
[9 / 13] JavaToolchainCompileClasses external/rules_java~/toolchains/platformclasspath_classes; 0s processwrapper-sandbox ... (2 actions, 1 running)
[12 / 13] [Prepa] Building license.check.license_check.jar ()
INFO: Found 1 target...
Target //:license.check.license_check up-to-date:
  bazel-bin/license.check.license_check
  bazel-bin/license.check.license_check.jar
INFO: Elapsed time: 18.818s, Critical Path: 2.38s
INFO: 13 processes: 9 internal, 3 processwrapper-sandbox, 1 worker.
INFO: Build completed successfully, 13 total actions
INFO: Running command line: bazel-bin/license.check.license_check ./formatted.txt -review -project automotive.score -repo https://github.com/eclipse-score/score -token otyhZ4eaRYK1tKLNNF-Y
[main] INFO Querying Eclipse Foundation for license data for 76 items.
[main] INFO Found 52 items.
[main] INFO Querying ClearlyDefined for license data for 24 items.
[main] INFO Found 24 items.
[main] INFO Vetted license information was found for all content. No further investigation is required.

@github-actions
Copy link

github-actions bot commented Mar 18, 2025

The created documentation from the pull request is available at: docu-html

@pahmann pahmann force-pushed the pahmann_verification_types_methods branch 2 times, most recently from 465c4a8 to 655f13a Compare March 25, 2025 15:17
@pahmann pahmann marked this pull request as draft March 25, 2025 16:06
@pahmann pahmann linked an issue Mar 25, 2025 that may be closed by this pull request
The methods of ISO 26262 shall be explained #497
Closed
@pahmann pahmann added this to the Process & Tools Enable Testing milestone Mar 27, 2025
@pahmann pahmann self-assigned this Mar 27, 2025
aschemmel-tech
aschemmel-tech requested changes Apr 3, 2025
View reviewed changes
Copy link
Contributor

@aschemmel-tech aschemmel-tech left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

see inline comments

aschemmel-tech
aschemmel-tech reviewed Apr 3, 2025
View reviewed changes
docs/process/process_areas/verification/guidance/verification_process_toolreqs.rst
Copy link
Contributor

@aschemmel-tech aschemmel-tech Apr 3, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please align with new definition what is used in S-CORE and remove all TestTypes which are not tests: e.g. inspection, walkthrough, static code analysis, ...

Copy link
Member Author

@pahmann pahmann Apr 8, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As test types only real test types should be applicable and not all methods. This requirement has to be adjusted to reflect the change properly. Agree and will implement this.

Copy link
Member Author

@pahmann pahmann Apr 9, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done.

Copy link
Contributor

@aschemmel-tech aschemmel-tech Apr 10, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Structural coverage should not be a TestType - we do not add a test just to add "structural coverage"

Copy link
Member Author

@pahmann pahmann Apr 10, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done with commit 766e44a

@pahmann pahmann marked this pull request as ready for review April 9, 2025 11:38
@pahmann
Copy link
Member Author

pahmann commented Apr 9, 2025

Sorry, my fault. Did a merge commit rather than a rebase. Will correct it.

pahmann and others added 7 commits April 9, 2025 14:23
@pahmann
process: verification guide for types and methods
027687a 
Additionally, addressing Typos.

see #497

Co-authored-by: Alexander Schemmel <alexander.schemmel@bmw.de>

Signed-off-by: Philipp Ahmann <Philipp.Ahmann@de.bosch.com>
@pahmann
process: add condition coverage as testing method
3c71a9f 
see #497

Signed-off-by: Philipp Ahmann <Philipp.Ahmann@de.bosch.com>
@pahmann
process: improve condition coverage guide
47fc25d 
see #497

Signed-off-by: Philipp Ahmann <Philipp.Ahmann@de.bosch.com>
@pahmann
process: condition vs branch coverage example
7f789d9 
see #497

Signed-off-by: Philipp Ahmann <Philipp.Ahmann@de.bosch.com>
@pahmann
process: fix test method review findings
4bc5dbd 
see #497
@aschemmel-tech @pahmann
process: correct branch coverage description
2f23a0e 
Ref: solves #497
@pahmann
Merge branch 'main' into pahmann_verification_types_methods
3098f26 
Signed-off-by: Philipp Ahmann <Philipp.Ahmann@de.bosch.com>
@pahmann pahmann force-pushed the pahmann_verification_types_methods branch from f08e587 to 3098f26 Compare April 9, 2025 14:31
pahmann added 2 commits April 9, 2025 14:39
@pahmann
process: fix documentation build error
6371f3c 
see #497

Signed-off-by: Philipp Ahmann <Philipp.Ahmann@de.bosch.com>
@pahmann
process: split verification methods into own file
2c80024 
closes #497

Signed-off-by: Philipp Ahmann <Philipp.Ahmann@de.bosch.com>
@pahmann
process: correct wrong condition coverage mentioning
9460d9a 
closes #497

Signed-off-by: Philipp Ahmann <Philipp.Ahmann@de.bosch.com>
@pahmann
process: remove structural coverage test type
766e44a 
close #497

Signed-off-by: Philipp Ahmann <Philipp.Ahmann@de.bosch.com>
aschemmel-tech
aschemmel-tech approved these changes Apr 10, 2025
View reviewed changes
Copy link
Contributor

@aschemmel-tech aschemmel-tech left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

all good now

@pahmann pahmann merged commit 76a92b7 into main Apr 10, 2025
10 checks passed
@pahmann pahmann deleted the pahmann_verification_types_methods branch April 10, 2025 12:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@masc2023 masc2023 masc2023 left review comments

@aschemmel-tech aschemmel-tech aschemmel-tech approved these changes

@hoe-jo hoe-jo Awaiting requested review from hoe-jo

Assignees

@pahmann pahmann

Labels

community:process community:testing

Projects

PIM - Process Implementation Community
Status: Done

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

The methods of ISO 26262 shall be explained

4 participants

@pahmann @masc2023 @aschemmel-tech