-
Notifications
You must be signed in to change notification settings - Fork 76
Doc: Implementation Process Description #526
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
vinodreddy-g
merged 5 commits into
eclipse-score:main
from
qorix-group:vohae_detailed_design
Mar 14, 2025
Merged
Changes from all commits
Commits
Show all changes
5 commits
Select commit
Hold shift + click to select a range
de1c584
doc: Implementation Process Description
PandaeDo c874944
doc: Detailed Design concept and example
vinodreddy-g b3e50b5
doc: implement review comments
PandaeDo cbf94a8
process: fix copyright check plantuml
PandaeDo 36a8de5
docs: fix CR header
dcalavrezo-qorix File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
30 changes: 30 additions & 0 deletions
30
docs/process/process_areas/implementation/_assets/dd_example_ex_dyn.puml
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,30 @@ | ||
| /' | ||
| # ******************************************************************************* | ||
| # Copyright (c) 2024 Contributors to the Eclipse Foundation | ||
| # | ||
| # See the NOTICE file(s) distributed with this work for additional | ||
| # information regarding copyright ownership. | ||
| # | ||
| # This program and the accompanying materials are made available under the | ||
| # terms of the Apache License Version 2.0 which is available at | ||
| # https://www.apache.org/licenses/LICENSE-2.0 | ||
| # | ||
| # SPDX-License-Identifier: Apache-2.0 | ||
| # ******************************************************************************* | ||
| '/ | ||
| .. | ||
|
|
||
| @startuml | ||
|
|
||
| title Sequence Diagram - unit1 & unit2 | ||
|
|
||
| participant "unit1" as unit1 | ||
| participant "unit2" as unit2 | ||
|
|
||
| unit1 -> unit2 : api1 | ||
| unit2 --> unit1 : int | ||
|
|
||
| unit1 -> unit2 : api3 | ||
| unit2 --> unit1 : int | ||
|
|
||
| @enduml |
37 changes: 37 additions & 0 deletions
37
docs/process/process_areas/implementation/_assets/dd_example_ex_sta.puml
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,37 @@ | ||
| /' | ||
| # ******************************************************************************* | ||
| # Copyright (c) 2024 Contributors to the Eclipse Foundation | ||
| # | ||
| # See the NOTICE file(s) distributed with this work for additional | ||
| # information regarding copyright ownership. | ||
| # | ||
| # This program and the accompanying materials are made available under the | ||
| # terms of the Apache License Version 2.0 which is available at | ||
| # https://www.apache.org/licenses/LICENSE-2.0 | ||
| # | ||
| # SPDX-License-Identifier: Apache-2.0 | ||
| # ******************************************************************************* | ||
| '/ | ||
| .. | ||
|
|
||
| @startuml | ||
|
|
||
| title Static View - dd example | ||
|
|
||
| skinparam component { | ||
| BackgroundColor<<component>> white | ||
| } | ||
|
|
||
| skinparam rectangle { | ||
| BackgroundColor<<unit>> green | ||
| } | ||
|
|
||
| ' Define Features | ||
| component "component1" <<component>> { | ||
| rectangle "unit1" as unit1 <<unit>> | ||
| rectangle "unit2" as unit2 <<unit>> | ||
| } | ||
|
|
||
| unit1 ..> unit2 : uses | ||
|
|
||
| @enduml |
86 changes: 86 additions & 0 deletions
86
docs/process/process_areas/implementation/_assets/detailed_design_example.rst
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,86 @@ | ||
| .. | ||
| # ******************************************************************************* | ||
| # Copyright (c) 2025 Contributors to the Eclipse Foundation | ||
| # | ||
| # See the NOTICE file(s) distributed with this work for additional | ||
| # information regarding copyright ownership. | ||
| # | ||
| # This program and the accompanying materials are made available under the | ||
| # terms of the Apache License Version 2.0 which is available at | ||
| # https://www.apache.org/licenses/LICENSE-2.0 | ||
| # | ||
| # SPDX-License-Identifier: Apache-2.0 | ||
| # ******************************************************************************* | ||
|
|
||
| Detailed Design for Component: component1 | ||
| ========================================= | ||
|
|
||
| Description | ||
| ----------- | ||
|
|
||
| - component is split into two units unit1 and unit2 based on single responsibility principle. | ||
| - unit2 is injected to unit1 one via dependency injection for testability. | ||
|
|
||
|
|
||
| Static Diagrams for Unit Interactions | ||
| ------------------------------------- | ||
|
|
||
| .. unit_dd_sta:: dd example static | ||
| :id: unit_dd_sta__dd_example_static | ||
| :security: NO | ||
| :safety: ASIL_B | ||
| :status: valid | ||
|
|
||
| .. uml:: dd_example_ex_sta.puml | ||
|
|
||
| Dynamic Diagrams for Unit Interactions | ||
| -------------------------------------- | ||
|
|
||
| .. unit_dd_dyn:: dd example dynamic | ||
| :id: unit_dd_dyn__dd_example_dynamic | ||
| :security: NO | ||
| :safety: ASIL_B | ||
| :status: valid | ||
|
|
||
| .. uml:: dd_example_ex_dyn.puml | ||
|
|
||
| Units within the Component | ||
| -------------------------- | ||
|
|
||
| .. unit_dd:: unit1 | ||
| :id: unit_dd__unit1 | ||
| :security: NO | ||
| :safety: ASIL_B | ||
| :status: valid | ||
|
|
||
| Placeholder for the description that will be generated from doxygen | ||
|
|
||
| Interface | ||
| ********* | ||
|
|
||
| .. unit_dd_int:: int1 | ||
| :id: unit_dd_int__unit1_int1 | ||
| :security: NO | ||
| :safety: ASIL_B | ||
| :status: valid | ||
|
|
||
| Placeholder for the description that will be generated from doxygen | ||
|
|
||
| .. unit_dd:: unit2 | ||
| :id: unit_dd__unit2 | ||
| :security: NO | ||
| :safety: ASIL_B | ||
| :status: valid | ||
|
|
||
| Placeholder for the description that will be generated from doxygen | ||
|
|
||
| Interface | ||
| ********* | ||
|
|
||
| .. unit_dd_int:: int2 | ||
| :id: unit_dd_int__unit2_int2 | ||
| :security: NO | ||
| :safety: ASIL_B | ||
| :status: valid | ||
|
|
||
| Placeholder for the description that will be generated from doxygen | ||
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Shall we create a process requirement for plotting an an automated figure compared to the architecture?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No , i think creating a static architecture at unit level to reflect a design pattern might be difficult to automate and i think might be better to do it manually to better think of the design.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Added as process requirements