clippy: added decision record on how to integrate clippy #2466
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Decision record document for clippy Signed-off-by: Dan Calavrezo <195309321+dcalavrezo-qorix@users.noreply.github.com>
dcalavrezo-qorix
requested review from
AlexanderLanin and
MaximilianSoerenPollak
as code owners
|
|
|
The created documentation from the pull request is available at: docu-html |
FScholPer
approved these changes
Jan 20, 2026
AlexanderLanin
approved these changes
Jan 26, 2026
LittleHuba
reviewed
Jan 27, 2026
Comment on lines
+58
to
+66
| - Use the shared aspect from `@score_rust_policies//clippy:linters.bzl` | ||
| (repo-local aspects remain an option if needed). | ||
| - Reference the centralized Clippy configuration from the policies repo: | ||
| `@score_rust_policies//clippy/strict:clippy.toml`. | ||
| - Enable the aspect in `.bazelrc` via `build --aspects=...%clippy` and request | ||
| output groups `rules_lint_human` (and optionally `rules_lint_machine`). | ||
| - Skip linting for specific targets using the `no-lint` tag. | ||
| - For CI, add `--@aspect_rules_lint//lint:fail_on_violation=true` to fail on findings. | ||
| - Use `aspect_rules_lint` >= `2.0.0-rc0` to support `fail_on_violation` with Clippy. |
Contributor
There was a problem hiding this comment.
This section might benefit from an example .bazelrc config with the relevant lines.
|
|
||
| ## 2. Decision | ||
|
|
||
| We adopt rules_lint for Clippy integration in S-CORE modules. |
Contributor
There was a problem hiding this comment.
Note, no blocker for merging:
https://github.com/eclipse-score/score_rust_policies/blob/main/README.md should be updated ASAP, so that there is no confusion.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Decision record document for clippy