-
Notifications
You must be signed in to change notification settings - Fork 76
Draft AoU on SW platform level on OS integration #1895
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
|
|
Need to resolve some issues before it's ready to review. |
Resolves: #1740 Signed-off-by: aschemmel-tech <aschemmel_job@arcor.de>
faa186f to
33e9a83
Compare
|
The created documentation from the pull request is available at: docu-html |
| Assumptions on the OS integration - Community Level | ||
| --------------------------------------------------- | ||
|
|
||
| This is the lowest level of integraton, the higher levels will build on this. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
typo, integration
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ok
| :id: aou_req__platform__os_integration_assistance | ||
| :reqtype: Non-Functional | ||
| :security: YES | ||
| :safety: ASIL_B |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Does this requirements be ASIL_B?, If used in combination with the highest level yes, but otherwise I would say no
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
change these to QM
| :id: aou_req__platform__os_bazel_tooling | ||
| :reqtype: Non-Functional | ||
| :security: YES | ||
| :safety: ASIL_B |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Wouldn't both community and functional platforms be categorized as "QM" for the safety level?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'd say the same. Everything up to and including the second tier/level cannot be ASIL but must be QM.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Or how does this :safety: need to be read? If the platform shall operate as ASIL-B, are all requirements of :safety: QM and the ones of :safety: ASIL_B needed? Or only the ones of :safety: ASIL_B? I'd have expected the "and"-semantics.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, change community/functional platform reqs to QM, will add additional clarifying AoU for ASIL_B.
opajonk
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
First thoughts from my side, and a few typos. Thanks a lot for creating this!
|
|
||
| The OS supplier shall perform safety anomaly reporting. | ||
|
|
||
| Note: This could be fulfilled by listimg per release version all known and user reported bugs which affect the safe OS functions. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| Note: This could be fulfilled by listimg per release version all known and user reported bugs which affect the safe OS functions. | |
| Note: This could be fulfilled by listing per release version all known and user reported bugs which affect the safe OS functions. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ok
| :id: aou_req__platform__os_bazel_tooling | ||
| :reqtype: Non-Functional | ||
| :security: YES | ||
| :safety: ASIL_B |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'd say the same. Everything up to and including the second tier/level cannot be ASIL but must be QM.
| :id: aou_req__platform__os_bazel_tooling | ||
| :reqtype: Non-Functional | ||
| :security: YES | ||
| :safety: ASIL_B |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Or how does this :safety: need to be read? If the platform shall operate as ASIL-B, are all requirements of :safety: QM and the ones of :safety: ASIL_B needed? Or only the ones of :safety: ASIL_B? I'd have expected the "and"-semantics.
| :safety: ASIL_B | ||
| :status: valid | ||
|
|
||
| The OS supplier shall provide tools for bazel to be able to build, run and test the S-CORE SW platform on the supplier OS. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| The OS supplier shall provide tools for bazel to be able to build, run and test the S-CORE SW platform on the supplier OS. | |
| The OS supplier shall provide tools for Bazel to be able to build, run and test the S-CORE SW platform on the supplier OS. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I agree with the "build" part, since software builds of S-CORE are done using Bazel - which is fine. I don't think test and run can be prescribed by S-CORE. OS's often use higher-level build/integration systems like BitBake etc., and running things (at least integration tests "upwards") often needs to be orchestrated in special ways. I don't think it is useful or necessary to require Bazel as frontent for these activities. I can be even impossible: if the building of e.g. the OS image requires certain tools to be used (qualification argumentation), this could create a serious conflict.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this could be a joint effort between the OS provider/supplier and S-CORE, where tests provided by the platform can be integrated into Bazel, if that makes sense.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Discussed and agreed a formulation change in the process community meeting Oct-21
f345e37 to
22a8768
Compare
22a8768 to
42cbea0
Compare
PandaeDo
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fine for me
Resolves: #1740