Skip to content

Conversation

@joshualicht
Copy link
Contributor

Change content:

  • update cargo.toml to allow creation of executable and library separately
  • add pico-args crate for command line interpretation
  • kvs_tool: provided with documentation and command line help in system

(Previous PR #5, which was already checked. Newly opened due to corrupted Git History after template rebase)

@github-actions
Copy link

github-actions bot commented Apr 29, 2025

License Check Results

🚀 The license check job ran with the Bazel command:

bazel run //:license-check

Status: ⚠️ Needs Review

Click to expand output
[License Check Output]
Extracting Bazel installation...
Starting local Bazel server (8.2.1) and connecting to it...
INFO: Invocation ID: 88a26fd5-7921-48d1-aaec-731d5a56776f
Computing main repo mapping: 
Computing main repo mapping: 
WARNING: For repository 'googletest', the root module requires module version googletest@1.14.0, but got googletest@1.14.0.bcr.1 in the resolved dependency graph. Please update the version in your MODULE.bazel or set --check_direct_dependencies=off
Loading: 
Loading: 0 packages loaded
Loading: 0 packages loaded
Analyzing: target //:license-check (1 packages loaded, 0 targets configured)
Analyzing: target //:license-check (1 packages loaded, 0 targets configured)

Analyzing: target //:license-check (52 packages loaded, 9 targets configured)

Analyzing: target //:license-check (65 packages loaded, 9 targets configured)

Analyzing: target //:license-check (103 packages loaded, 720 targets configured)

Analyzing: target //:license-check (111 packages loaded, 1981 targets configured)

Analyzing: target //:license-check (116 packages loaded, 2142 targets configured)

Analyzing: target //:license-check (119 packages loaded, 2160 targets configured)

Analyzing: target //:license-check (122 packages loaded, 4495 targets configured)

Analyzing: target //:license-check (124 packages loaded, 4739 targets configured)

DEBUG: Rule 'toolchains_llvm++llvm+llvm_toolchain_llvm' indicated that a canonical reproducible form can be obtained by modifying arguments _action_listener = <unknown object com.google.devtools.build.lib.packages.Attribute$LabelListLateBoundDefault>, _config_dependencies = [], _configure = False, _environ = [], _original_name = "llvm_toolchain_llvm"
DEBUG: Repository toolchains_llvm++llvm+llvm_toolchain_llvm instantiated at:
  <builtin>: in <toplevel>
Repository rule llvm defined at:
  /home/runner/.bazel/external/toolchains_llvm+/toolchain/rules.bzl:27:23: in <toplevel>
Analyzing: target //:license-check (124 packages loaded, 4739 targets configured)

INFO: Analyzed target //:license-check (125 packages loaded, 6677 targets configured).
[8 / 13] [Prepa] Expanding template external/score_dash_license_checker+/tool/formatters/dash_format_converter [for tool]
INFO: From Generating Dash formatted dependency file ...:
INFO: Successfully converted 4 packages from Cargo.lock to bazel-out/k8-fastbuild/bin/formatted.txt
INFO: Found 1 target...
Target //:license.check.license_check up-to-date:
  bazel-bin/license.check.license_check
  bazel-bin/license.check.license_check.jar
INFO: Elapsed time: 193.337s, Critical Path: 0.65s
INFO: 13 processes: 3 disk cache hit, 9 internal, 1 processwrapper-sandbox.
INFO: Build completed successfully, 13 total actions
INFO: Running command line: bazel-bin/license.check.license_check ./formatted.txt <args omitted>
[main] INFO Querying Eclipse Foundation for license data for 4 items.
[main] INFO Found 3 items.
[main] INFO License information could not be automatically verified for the following content:
[main] INFO 
[main] INFO cargo/cargo/-/rust-kvs/0.1.0
[main] INFO 
[main] INFO This content is either not correctly mapped by the system, or requires review.
[main] INFO A review is required for cargo/cargo/-/rust-kvs/0.1.0.
[main] INFO A review request already exists https://gitlab.eclipse.org/eclipsefdn/emo-team/iplab/-/issues/20866 .

Copy link

@guysagnes guysagnes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Verification done
Functionality checked

Open action to be aligned with process:
License Check Results

vinodreddy-g
vinodreddy-g previously approved these changes May 7, 2025
@vinodreddy-g vinodreddy-g self-requested a review May 7, 2025 11:41
@vinodreddy-g
Copy link
Contributor

@dcalavrezo-qorix the checks are failing , is it because of the usage of template?

@vinodreddy-g vinodreddy-g dismissed their stale review May 7, 2025 11:45

checks are failing

@dcalavrezo-qorix
Copy link
Contributor

@dcalavrezo-qorix the checks are failing , is it because of the usage of template?

no, someone must have broken something, I will check

@dcalavrezo-qorix
Copy link
Contributor

@joshualicht can you update the version of the score_format_checker to 0.1.1 pleasE?

@joshualicht
Copy link
Contributor Author

@vinodreddy-g @dcalavrezo-qorix Update of score_format_checker to version 0.1.1 done: Formatting checks passed

@vinodreddy-g vinodreddy-g merged commit 376cf8d into eclipse-score:main May 7, 2025
7 of 8 checks passed
@github-project-automation github-project-automation bot moved this from In progress to Done in PER - Persistency FT May 7, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

5 participants