Skip to content

Conversation

@arkjedrz
Copy link
Contributor

@arkjedrz arkjedrz commented Jan 19, 2026

  • Add .clang-format file at the repo root.
  • Run clang-format over all C++ files.

Resolves #218

@arkjedrz arkjedrz requested a review from PiotrKorkus January 19, 2026 12:40
@github-actions
Copy link

github-actions bot commented Jan 19, 2026

License Check Results

🚀 The license check job ran with the Bazel command:

bazel run //:license-check

Status: ⚠️ Needs Review

Click to expand output
[License Check Output]
Extracting Bazel installation...
Starting local Bazel server (8.3.0) and connecting to it...
INFO: Invocation ID: 250b29ec-bb63-4226-a8c1-5b7acc989336
Computing main repo mapping: 
Computing main repo mapping: 
Computing main repo mapping: 
Computing main repo mapping: 
Computing main repo mapping: 
DEBUG: Rule 'rust_qnx8_toolchain+' indicated that a canonical reproducible form can be obtained by modifying arguments integrity = "sha256-oEubHgeZDdT0svMmBKJx7c3/2TdSI/vfwRUyDn+TPGA="
DEBUG: Repository rust_qnx8_toolchain+ instantiated at:
  <builtin>: in <toplevel>
Repository rule http_archive defined at:
  /home/runner/.bazel/external/bazel_tools/tools/build_defs/repo/http.bzl:394:31: in <toplevel>
Computing main repo mapping: 
Computing main repo mapping: 
Computing main repo mapping: 
WARNING: For repository 'score_process', the root module requires module version score_process@1.3.2, but got score_process@1.4.0 in the resolved dependency graph. Please update the version in your MODULE.bazel or set --check_direct_dependencies=off
Computing main repo mapping: 
Loading: 
Loading: 3 packages loaded
Loading: 3 packages loaded
    currently loading: 
Analyzing: target //:license-check (4 packages loaded, 0 targets configured)
Analyzing: target //:license-check (4 packages loaded, 0 targets configured)

Analyzing: target //:license-check (86 packages loaded, 10 targets configured)

Analyzing: target //:license-check (153 packages loaded, 2226 targets configured)

Analyzing: target //:license-check (159 packages loaded, 6997 targets configured)

Analyzing: target //:license-check (159 packages loaded, 6997 targets configured)

INFO: Analyzed target //:license-check (162 packages loaded, 9013 targets configured).
[13 / 14] [Prepa] Generating Dash formatted dependency file ...
INFO: From Generating Dash formatted dependency file ...:
INFO: Successfully converted 62 packages from Cargo.lock to bazel-out/k8-fastbuild/bin/formatted.txt
INFO: Found 1 target...
Target //:license.check.license_check up-to-date:
  bazel-bin/license.check.license_check
  bazel-bin/license.check.license_check.jar
INFO: Elapsed time: 22.928s, Critical Path: 0.31s
INFO: 14 processes: 5 disk cache hit, 9 internal.
INFO: Build completed successfully, 14 total actions
INFO: Running command line: bazel-bin/license.check.license_check ./formatted.txt <args omitted>
usage: org.eclipse.dash.licenses.cli.Main [-batch <int>] [-cd <url>]
       [-confidence <int>] [-ef <url>] [-excludeSources <sources>] [-help] [-lic
       <url>] [-project <shortname>] [-repo <url>] [-review] [-summary <file>]
       [-timeout <seconds>] [-token <token>]

@github-actions
Copy link

The created documentation from the pull request is available at: docu-html

@arkjedrz arkjedrz force-pushed the arkjedrz_cpp-formatting branch from 538d40a to a8cde05 Compare January 19, 2026 12:46
@arkjedrz arkjedrz self-assigned this Jan 19, 2026
PiotrKorkus
PiotrKorkus previously approved these changes Jan 19, 2026
Copy link
Contributor

@PiotrKorkus PiotrKorkus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

In SCORE the rules have not been agreed yet - https://eclipse-score.github.io/score/main/contribute/development/cpp/coding_guidelines.html#code-style
But there is a benefit to have it unified at least across repo

Copy link
Contributor

@vinodreddy-g vinodreddy-g left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@arkjedrz Lets use this from comm repo - https://github.com/eclipse-score/communication/blob/main/.clang-format. Easier to align in s-core with this i guess.

Config is based on the one from comm repo.
- Add `.clang-format` file at the repo root.
- Run `clang-format` over all C++ files.
@arkjedrz arkjedrz force-pushed the arkjedrz_cpp-formatting branch from a2b20ea to 52dac33 Compare January 19, 2026 13:08
@PiotrKorkus PiotrKorkus merged commit 163ea25 into eclipse-score:main Jan 19, 2026
14 checks passed
Copy link
Contributor

@vinodreddy-g vinodreddy-g left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@arkjedrz arkjedrz deleted the arkjedrz_cpp-formatting branch January 19, 2026 13:28
tizava pushed a commit to etas-contrib/score_persistency that referenced this pull request Jan 23, 2026
…rmatting

repo: add `.clang-format` file, format C++
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Improvement: CPP formatting

3 participants