-
Notifications
You must be signed in to change notification settings - Fork 24
repo: add .clang-format file, format C++
#219
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
repo: add .clang-format file, format C++
#219
Conversation
License Check Results🚀 The license check job ran with the Bazel command: bazel run //:license-checkStatus: Click to expand output |
|
The created documentation from the pull request is available at: docu-html |
538d40a to
a8cde05
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
In SCORE the rules have not been agreed yet - https://eclipse-score.github.io/score/main/contribute/development/cpp/coding_guidelines.html#code-style
But there is a benefit to have it unified at least across repo
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@arkjedrz Lets use this from comm repo - https://github.com/eclipse-score/communication/blob/main/.clang-format. Easier to align in s-core with this i guess.
a8cde05 to
a2b20ea
Compare
Config is based on the one from comm repo. - Add `.clang-format` file at the repo root. - Run `clang-format` over all C++ files.
a2b20ea to
52dac33
Compare
vinodreddy-g
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
…rmatting repo: add `.clang-format` file, format C++
.clang-formatfile at the repo root.clang-formatover all C++ files.Resolves #218