Skip to content

impl: logging support #206

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
arkjedrz wants to merge 1 commit into
base: main
Choose a base branch
from
Open

impl: logging support #206

arkjedrz wants to merge 1 commit into from

Conversation

@arkjedrz
Copy link
Contributor

@arkjedrz arkjedrz commented Jan 7, 2026 •
edited
Loading

  • Use stdout_logger backend for Cargo builds.
  • Use score_log_bridge backend for Bazel builds.
  • Additional logs from Rust implementation.
  • Use proxy module for logging with correct context across the lib.
  • Fix tests.
  • Bump toolchain version.

@arkjedrz arkjedrz marked this pull request as draft January 7, 2026 15:01
@arkjedrz arkjedrz requested a review from pawelrutkaq January 7, 2026 15:01
@github-actions
Copy link

github-actions bot commented Jan 7, 2026 •
edited
Loading

License Check Results

🚀 The license check job ran with the Bazel command:

bazel run //:license-check

Status: ⚠️ Needs Review

Click to expand output 
[License Check Output]
Extracting Bazel installation...
Starting local Bazel server (8.3.0) and connecting to it...
INFO: Invocation ID: afa2dbc8-e6fb-413d-a29d-5e120b2b910c
Computing main repo mapping: 
Computing main repo mapping: 
Computing main repo mapping: 
Computing main repo mapping: 
Computing main repo mapping: 
Computing main repo mapping: 
DEBUG: Rule 'rust_qnx8_toolchain+' indicated that a canonical reproducible form can be obtained by modifying arguments integrity = "sha256-oEubHgeZDdT0svMmBKJx7c3/2TdSI/vfwRUyDn+TPGA="
DEBUG: Repository rust_qnx8_toolchain+ instantiated at:
  <builtin>: in <toplevel>
Repository rule http_archive defined at:
  /home/runner/.bazel/external/bazel_tools/tools/build_defs/repo/http.bzl:394:31: in <toplevel>
Computing main repo mapping: 
Computing main repo mapping: 
WARNING: For repository 'rules_python', the root module requires module version rules_python@1.4.1, but got rules_python@1.5.1 in the resolved dependency graph. Please update the version in your MODULE.bazel or set --check_direct_dependencies=off
WARNING: For repository 'score_rust_policies', the root module requires module version score_rust_policies@0.0.2, but got score_rust_policies@0.0.3 in the resolved dependency graph. Please update the version in your MODULE.bazel or set --check_direct_dependencies=off
WARNING: For repository 'rules_cc', the root module requires module version rules_cc@0.1.2, but got rules_cc@0.2.8 in the resolved dependency graph. Please update the version in your MODULE.bazel or set --check_direct_dependencies=off
WARNING: For repository 'googletest', the root module requires module version googletest@1.17.0.bcr.1, but got googletest@1.17.0.bcr.2 in the resolved dependency graph. Please update the version in your MODULE.bazel or set --check_direct_dependencies=off
WARNING: For repository 'score_bazel_platforms', the root module requires module version score_bazel_platforms@0.0.2, but got score_bazel_platforms@0.0.3 in the resolved dependency graph. Please update the version in your MODULE.bazel or set --check_direct_dependencies=off
WARNING: For repository 'score_process', the root module requires module version score_process@1.3.2, but got score_process@1.4.0 in the resolved dependency graph. Please update the version in your MODULE.bazel or set --check_direct_dependencies=off
Computing main repo mapping: 
Computing main repo mapping: 
Loading: 
Loading: 4 packages loaded
Loading: 4 packages loaded
    currently loading: 
Analyzing: target //:license-check (5 packages loaded, 0 targets configured)
Analyzing: target //:license-check (5 packages loaded, 0 targets configured)

Analyzing: target //:license-check (84 packages loaded, 10 targets configured)

Analyzing: target //:license-check (158 packages loaded, 1964 targets configured)

Analyzing: target //:license-check (166 packages loaded, 7391 targets configured)

Analyzing: target //:license-check (166 packages loaded, 7391 targets configured)

INFO: Analyzed target //:license-check (169 packages loaded, 9407 targets configured).
[10 / 14] Executing genrule //:filtered_cargo_lock; 0s disk-cache, processwrapper-sandbox ... (2 actions, 1 running)
INFO: From Generating Dash formatted dependency file ...:
INFO: Successfully converted 66 packages from Cargo.lock to bazel-out/k8-fastbuild/bin/formatted.txt
INFO: Found 1 target...
Target //:license.check.license_check up-to-date:
  bazel-bin/license.check.license_check
  bazel-bin/license.check.license_check.jar
INFO: Elapsed time: 25.724s, Critical Path: 0.69s
INFO: 14 processes: 3 disk cache hit, 9 internal, 2 processwrapper-sandbox.
INFO: Build completed successfully, 14 total actions
INFO: Running command line: bazel-bin/license.check.license_check ./formatted.txt <args omitted>
usage: org.eclipse.dash.licenses.cli.Main [-batch <int>] [-cd <url>]
       [-confidence <int>] [-ef <url>] [-excludeSources <sources>] [-help] [-lic
       <url>] [-project <shortname>] [-repo <url>] [-review] [-summary <file>]
       [-timeout <seconds>] [-token <token>]

@arkjedrz arkjedrz force-pushed the arkjedrz_enable-logging-2 branch from 77bc368 to d9faad5 Compare January 7, 2026 15:06
pawelrutkaq
pawelrutkaq reviewed Jan 7, 2026
View reviewed changes
src/rust/rust_kvs_tool/BUILD Outdated
"@score_baselibs_rust//src/log/mw_log",
"@score_crates//:pico_args",
"@score_crates//:tinyjson",
"@score_logging//src/rust/mw_logger",
Copy link
Contributor

@pawelrutkaq pawelrutkaq Jan 7, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can't rustc_flags comes from mw_logger ?

Copy link
Contributor Author

@arkjedrz arkjedrz Jan 7, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Won't work without them.

MODULE.bazel
commit = "5a70133dd8bd632f5c07f200a5ee4bc9f507c23b",
remote = "https://github.com/eclipse-score/communication.git",
)

Copy link
Contributor

@pawelrutkaq pawelrutkaq Jan 7, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we wait with PR until logging is fixed.

@arkjedrz arkjedrz force-pushed the arkjedrz_enable-logging-2 branch 5 times, most recently from b065c66 to ba914d3 Compare January 8, 2026 09:55
@arkjedrz arkjedrz requested a review from vinodreddy-g January 8, 2026 13:53
@arkjedrz arkjedrz self-assigned this Jan 12, 2026
@arkjedrz arkjedrz force-pushed the arkjedrz_enable-logging-2 branch 2 times, most recently from 3594ed5 to 18dc8b8 Compare January 15, 2026 08:19
@arkjedrz arkjedrz mentioned this pull request Jan 15, 2026
Closed
vinodreddy-g
vinodreddy-g reviewed Jan 16, 2026
View reviewed changes
src/rust/rust_kvs/Cargo.toml Outdated
[dependencies]
adler32.workspace = true
tinyjson.workspace = true
mw_log.workspace = true
Copy link
Contributor

@vinodreddy-g vinodreddy-g Jan 16, 2026 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the build with cargo only works with stdlogger right?

Copy link
Contributor Author

@arkjedrz arkjedrz Jan 19, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, but to be clear - this is not due to some issues or limitations. stdout_logger is just the only implementation that exists and interoperates with Cargo.
rust_kvs does not specify backend, because it can work with any.

@arkjedrz arkjedrz force-pushed the arkjedrz_enable-logging-2 branch from 18dc8b8 to c2eabd7 Compare January 19, 2026 13:48
@arkjedrz arkjedrz force-pushed the arkjedrz_enable-logging-2 branch 5 times, most recently from ac5219a to d110ca3 Compare January 23, 2026 08:12
@arkjedrz arkjedrz marked this pull request as ready for review January 23, 2026 08:13
PiotrKorkus
PiotrKorkus reviewed Jan 27, 2026
View reviewed changes
BUILD Outdated
Comment on lines 23 to 24
# "@score_platform//:needs_json",
# "@score_process//:needs_json",
Copy link
Contributor

@PiotrKorkus PiotrKorkus Jan 27, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is why external needs are not found and docs do not build

@arkjedrz
impl: use score_log for logs
d4b1afa 
- Use `stdout_logger` for Cargo builds.
- Use `score_log_bridge` for Bazel builds.
- Additional logs from Rust implementation.
- Use proxy module for logging with correct context across the lib.
- Fix tests.
- Bump toolchain version.
@arkjedrz arkjedrz force-pushed the arkjedrz_enable-logging-2 branch from d110ca3 to d4b1afa Compare January 27, 2026 14:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@PiotrKorkus PiotrKorkus PiotrKorkus left review comments

@vinodreddy-g vinodreddy-g Awaiting requested review from vinodreddy-g vinodreddy-g is a code owner

@pawelrutkaq pawelrutkaq Awaiting requested review from pawelrutkaq

At least 1 approving review is required to merge this pull request.

Assignees

@arkjedrz arkjedrz

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@arkjedrz @vinodreddy-g @pawelrutkaq @PiotrKorkus