Skip to content

Conversation

@opajonk
Copy link
Contributor

@opajonk opajonk commented Feb 2, 2026

  • Add Overall Result job which depends on all required status checks
  • Add merge_group event

Copy link

@JP-ETAS JP-ETAS Feb 3, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You could make a new workflow merge-queue.yaml and call this workflow from that one. This would mean you don't need your overall-result job as you could just use the merge-queue.yaml workflow status directly.

Would also be clear in the code if someone wanted to extend the merge queue tests in the future

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I must say I am not a fan of workflows including workflows... it just starts to be convoluted really quickly, and I need to jump between files when editing, think about branches, etc.

Here, I'd argue the workflow is really short enough and we should not use multiple files.

We can discuss the naming of the steps, though. I am not entirely happy yet. I like solutions like described here. What do you think?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK, admittedly it is possible to omit the branch ref if it is in the same repository. And it should probably be done almost always, unless one wants to run into weird issues. But again - here, the workflow is so short... why add complexity.

@opajonk opajonk force-pushed the prepare_merge_queue branch from e87fb77 to b77138a Compare February 3, 2026 11:49
- Add Overall Result job which depends on all required status checks
- Add merge_group event
@opajonk opajonk force-pushed the prepare_merge_queue branch from b77138a to 35457fe Compare February 3, 2026 16:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants