Skip to content

qnx: make mman_impl LP64-safe; use ::mmap/::mem_offset on QNX LP64 and include <sys/mman.h>, <sys/types.h> #27

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

qnx: make mman_impl LP64-safe; use ::mmap/::mem_offset on QNX LP64 and include <sys/mman.h>, <sys/types.h> #27

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
31 changes: 18 additions & 13 deletions score/os/qnx/mman_impl.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,8 @@
* SPDX-License-Identifier: Apache-2.0
********************************************************************************/
#include "score/os/qnx/mman_impl.h"

#include <sys/mman.h>
#include <sys/types.h>
namespace score
{
namespace os
Expand All @@ -21,14 +22,14 @@ namespace qnx

/* KW_SUPPRESS_START:MISRA.VAR.HIDDEN:Wrapper function is identifiable through namespace usage */
score::cpp::expected<void*, Error> MmanQnxImpl::mmap(void* const addr,
const std::size_t length,
const std::int32_t protection,
const std::int32_t flags,
const std::int32_t fd,
const std::int64_t offset) const noexcept
const std::size_t length,
const std::int32_t protection,
const std::int32_t flags,
const std::int32_t fd,
const std::int64_t offset) const noexcept
/* KW_SUPPRESS_END:MISRA.VAR.HIDDEN:Wrapper function is identifiable through namespace usage */
{
void* const ret{::mmap(addr, length, protection, flags, fd, offset)};
void* const ret{::mmap(addr, length, protection, flags, fd, offset)};
/* KW_SUPPRESS_START:AUTOSAR.CAST.CSTYLE:Cast is happening outside our code domain */
/* KW_SUPPRESS_START:MISRA.USE.EXPANSION: Using library-defined macro to ensure correct operations */
// Suppress "autosar_cpp14_m5_2_9_violation" rule finding. This rule states: "A cast shall not
Expand All @@ -53,12 +54,12 @@ score::cpp::expected<void*, Error> MmanQnxImpl::mmap64(void* addr,
const std::int32_t fd,
const std::int64_t offset) const noexcept
{
#if defined(__QNX__) && defined(__LP64__)
// On LP64 QNX, mmap already uses 64-bit offsets.
void* const ret{::mmap(addr, length, protection, flags, fd, offset)};
#else
void* const ret{::mmap64(addr, length, protection, flags, fd, offset)};
/* KW_SUPPRESS_START:AUTOSAR.CAST.CSTYLE:Cast is happening outside our code domain */
/* KW_SUPPRESS_START:MISRA.USE.EXPANSION: Using library-defined macro to ensure correct operations */
// Cast is happening outside our code domain
// coverity[autosar_cpp14_m5_2_9_violation]
// coverity[autosar_cpp14_a5_2_2_violation] MAP_FAILED is builtin macro
#endif
if (ret == MAP_FAILED)
/* KW_SUPPRESS_END:MISRA.USE.EXPANSION: Using library-defined macro to ensure correct operations */
/* KW_SUPPRESS_END:AUTOSAR.CAST.CSTYLE:Cast is happening outside our code domain */
Expand Down Expand Up @@ -202,13 +203,17 @@ score::cpp::expected_blank<Error> MmanQnxImpl::mem_offset64(const void* addr,
std::size_t* contig_len) const noexcept
/* KW_SUPPRESS_END:MISRA.VAR.HIDDEN:Wrapper function is identifiable through namespace usage */
{
#if defined(__QNX__) && defined(__LP64__)
// On LP64 QNX only mem_offset() exists; off_t is 64-bit already.
if (::mem_offset(addr, fd, length,offset,contig_len) == -1)
#else
if (::mem_offset64(addr, fd, length, offset, contig_len) == -1)
#endif
{
return score::cpp::make_unexpected(Error::createFromErrno());
}
return {};
}

} // namespace qnx
} // namespace os
} // namespace score