-
Notifications
You must be signed in to change notification settings - Fork 31
Add S-CORE devcontainer #15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
aed8884 to
dc20110
Compare
6a4704f to
9655388
Compare
|
@bl81hi Can you test this one with Docker on Windows? If this works we can simplify the devcontainers in the other repos. |
lgtm - thanks a lot! |
9655388 to
6fff4e6
Compare
6fff4e6 to
3b5f851
Compare
The devcontainer eases setup a lot and create a reproducible environment.
This helps figuring out issues, which are only seen in CI.
8a5115b to
551eb39
Compare
I can recall that it was failing two tests related to setgid/setuid (in unistdTest.cpp). I suspect that they would pass if the container was run in privileged mode. So no, probably not related to #7 |
The problem still is that the devcontainer has no release to which CI could be pinned. This was also reverted in eclipse-score/communication@58aaf80 When we have container versions, there should be no argument anymore not to use the container in CI.
Yes those are failing.
This did not work, but the error is still the same: |
The devcontainer eases setup a lot and creates a reproducible environment.
Currently some tests fail in the devcontainer, which I did not debug yet.