-
Notifications
You must be signed in to change notification settings - Fork 31
Use system dependencies #14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
tmewett
wants to merge
9
commits into
eclipse-score:main
Choose a base branch
from
tmewett:use-system-deps
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Changes from all commits
Commits
Show all changes
9 commits
Select commit
Hold shift + click to select a range
cf3b3fe
Use system compiler
tmewett 84dd12f
Use system Boost
tmewett aa2f535
Use system valgrind
tmewett d45abb1
Use system libacl
tmewett 3ec6e76
Use system nlohmann_json
tmewett ec5437b
Use system libcap2
tmewett 9460fae
Use system libseccomp2
tmewett 4660030
MODULE.bazel: Remove now-unused download_utils
tmewett 70e27e6
Update MODULE.bazel.lock
tmewett File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Large diffs are not rendered by default.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,5 +1,5 @@ | ||
| alias( | ||
| cc_library( | ||
| name = "acl", | ||
| actual = "@acl-deb//:acl", | ||
| visibility = ["//visibility:public"], | ||
| ) | ||
| linkopts = ["-lacl"], | ||
| visibility = ["//visibility:public"], | ||
| ) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,19 +1,5 @@ | ||
| alias( | ||
| cc_library( | ||
| name = "container", | ||
| actual = "@boost//:container", | ||
| visibility =["//visibility:public"], | ||
| linkopts = ["-lboost_container"], | ||
| visibility = ["//visibility:public"], | ||
| ) | ||
|
|
||
|
|
||
| alias( | ||
| name = "interprocess", | ||
| actual = "@boost//:interprocess", | ||
| visibility =["//visibility:public"], | ||
| ) | ||
|
|
||
|
|
||
| alias( | ||
| name = "program_options", | ||
| actual = "@boost//:program_options", | ||
| visibility =["//visibility:public"], | ||
| ) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,5 +1,5 @@ | ||
| alias( | ||
| cc_library( | ||
| name = "libcap2", | ||
| actual = "@libcap2-dev-deb//:libcap2", | ||
| visibility = ["//visibility:public"], | ||
| ) | ||
| linkopts = ["-lcap"], | ||
| visibility = ["//visibility:public"], | ||
| ) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,5 +1,5 @@ | ||
| alias( | ||
| cc_library( | ||
| name = "libseccomp2", | ||
| actual = "@libseccomp2-dev-deb//:libseccomp2", | ||
| visibility = ["//visibility:public"], | ||
| ) | ||
| linkopts = ["-lseccomp"], | ||
| visibility = ["//visibility:public"], | ||
| ) |
This file was deleted.
Oops, something went wrong.
This file was deleted.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This isn't a good solution for compiler flags, since this
.bazelrcis not applied when building this project as a dependenciy via another Bazel project.A better approach would be to define a toolchain in Bazel which just wraps the system compiler and exposes flags as features.