Enable anti-aliasing for Terminal text#2463
Enable anti-aliasing for Terminal text#2463iloveeclipse merged 1 commit intoeclipse-platform:masterfrom
Conversation
HeikoKlare
left a comment
There was a problem hiding this comment.
This change improves the situation for Windows with differing "quality" depending on the actual conditions.
Note that the issue not improved because of using anti-aliasing but because of the implicit enablement of advanced mode for the GC. On Windows, this enabled GDI+, which produces the different results in text extent calculation and/or text rendering. So in my understanding, changing setAntialias(SWT.ON) to setAdvance(true) would also resolve the issue.
On primary monitor
When operating on the primary monitor, the issue seems to resolve cut-off characters on Windows.
**On non-primary monitor:
When operating on a non-primary monitor, the issue is reduced. In the following example, you see that the text is less cuf-off before the "/"
Before:
You see that the text is less cut-off between before the "/".

Note that the longer a text segment is, the more text will be cut off, e.g.:
![]()
This is caused by the font not being interpreted as "proportional" (even though it actually is) on a non-primary monitor because of the wrong usage of a GC for extent calculation in StyleMap as explained here: #2295 (comment)
When adapting the GC creating in StyleMap to use the correct zoom, the results look quite correct with this change even on a secondary monitor:

With that understanding, I would be in favor of merging this. I will try to find a way to properly initialize the GC in StyleMap to further improve the behavior in multi-monitor setups.
|
@iloveeclipse just to be sure: you don't want to merge this as a last-minute fix for RC2 but wait for 2026-06, do you? |
I believe this could be merged as it should be small & innocent fix, but I believe it is too late for RC2, isn't? If there will be RC2a (usually we have one), this would be good candidate :-) |
|
The RC2/final build is tonight (I think 6:00PM EST) so we have all day for any safe final changes. I'll leave it to you guys' good judgement as to what is appropriate and safe to merge on the last day of the cycle. |
|
OK, with that I believe we can merge for RC2. |
I don't think so. You have my PL+1. Just for the sake of safety I have tested the change on MacOS and it is fine there as well (in the sense that it does not change any behavior as the text was antialiased already before). |
|
You guys are fully empowered to do the right thing in the best interests of the project. |
|
OK, thanks Heiko & Ed. Merging now. |
|
I was looking forward for a nicer rendering of the Terminal content since it was bugging me quiet some time. |
|
OMG. I see the slower UI repaints on view resize, slower output and slightly slower typing speed in the terminal. The question is whether it is worth to have crisp text inside or not? @trancexpress : could you please test on Linux with latest SDK build? Should we revert the change? |
|
I would say revert it and have the next cycle to have time to improve. We shouldn't be shipping such regressions as Eclipse is not a speed monster already. |
At least in my setup the situation became a bit better with respect to sharpness of the rendered text but it's not perfect and I still have other artifacts like ghost lines after resize.
That's my opinion too. |
This reverts commit c02addc as it slows down Terminal functionality. See comments on eclipse-platform#2463
|
See #2480 |
Checked with:
Actually no, when I start in my developer workspace resizing is a lot slower. I didn't notice anything in a new workspace, but with some views open and a Java editor, the UI is slower. |



FixesContributes to #2295