Resources / Runtime tests: Do not depend on higher-level plug-ins. #2161
+23
−8
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request changes some projects for the first time in this development cycle. An additional commit containing all the necessary changes was pushed to the top of this PR's branch. To obtain these changes (for example if you want to push more changes) either fetch from your fork or apply the git patch. Git patchFurther information are available in Common Build Issues - Missing version increments. |
laeubi
reviewed
Sep 15, 2025
Comment on lines
1104
to
1105
| String MULTI_FILT_ID = "org.eclipse.core.resources.regexFilterMatcher"; | ||
| String FILT_ARG = "foo.*"; |
There was a problem hiding this comment.
I must confess I don't understand what this actually does and where it is needed in the test but would trust your analysis here and it looks much more understandable than the previous version.
There was a problem hiding this comment.
Yeah, the test basically just wants any <filteredResources><filter>... in the .project metadata. And we should use one here that is actually known here (or upstream) :)
...re.tests.runtime/src/org/eclipse/core/tests/internal/preferences/PreferencesServiceTest.java
Outdated
Show resolved
Hide resolved
...re.tests.runtime/src/org/eclipse/core/tests/internal/preferences/PreferencesServiceTest.java
Show resolved
Hide resolved
* PreferencesServiceTest is not deterministic but its behavior changes depending on the presence of downstream plug-in org.eclipse.core.resources. Take this into account. * IResourceTest should not depend on downstream plug-in org.eclipse.ui.ide (even inside a downstream repository). Use a different (upstream) filter provider in the unit test instead. These downstream plug-ins are currently only visible because Tycho adds the full-blown UI test harness to the target platform unconditionally, even if there is no such actual dependency [1]. This is a cleanup in preparation for [2]. [1] eclipse-tycho/tycho#5349 [2] eclipse-tycho/tycho#5362
sratz
force-pushed
the
test-fixes-downstream-deps
branch
from
58e6c5b to
6b340ef
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PreferencesServiceTest is not deterministic but its behavior changes depending on the presence of downstream plug-in org.eclipse.core.resources. Take this into account.
IResourceTest should not depend on downstream plug-in org.eclipse.ui.ide (even inside a downstream repository). Use a different (upstream) filter provider in the unit test instead.
These downstream plug-ins are currently only visible because Tycho adds the full-blown UI test harness to the target platform unconditionally, even if there is no such actual dependency [1]. This is a cleanup in preparation for [2].
[1] eclipse-tycho/tycho#5349
[2] eclipse-tycho/tycho#5362