Skip to content

Conversation

SougandhS
Copy link
Contributor

@SougandhS SougandhS commented Sep 8, 2025

This PR introduces a toggle to enable or disable the display of elapsed time in the console output in Console settings.

Added support for customizing the format of the elapsed time, allowing users to choose from multiple display styles based on their preferences or requirements.

image
ConsoleH.mp4

fixes : #2112

@eclipse-platform-bot
Copy link
Contributor

This pull request changes some projects for the first time in this development cycle.
Therefore the following files need a version increment:

debug/org.eclipse.debug.ui/META-INF/MANIFEST.MF

An additional commit containing all the necessary changes was pushed to the top of this PR's branch. To obtain these changes (for example if you want to push more changes) either fetch from your fork or apply the git patch.

Git patch
From fbd2fdf674cf982d91c4d97bae585ee8a022e20e Mon Sep 17 00:00:00 2001
From: Eclipse Platform Bot <platform-bot@eclipse.org>
Date: Mon, 8 Sep 2025 05:09:28 +0000
Subject: [PATCH] Version bump(s) for 4.38 stream


diff --git a/debug/org.eclipse.debug.ui/META-INF/MANIFEST.MF b/debug/org.eclipse.debug.ui/META-INF/MANIFEST.MF
index 81279072c8..860867d420 100644
--- a/debug/org.eclipse.debug.ui/META-INF/MANIFEST.MF
+++ b/debug/org.eclipse.debug.ui/META-INF/MANIFEST.MF
@@ -2,7 +2,7 @@ Manifest-Version: 1.0
 Bundle-ManifestVersion: 2
 Bundle-Name: %pluginName
 Bundle-SymbolicName: org.eclipse.debug.ui; singleton:=true
-Bundle-Version: 3.19.0.qualifier
+Bundle-Version: 3.19.100.qualifier
 Bundle-Activator: org.eclipse.debug.internal.ui.DebugUIPlugin
 Bundle-Vendor: %providerName
 Bundle-Localization: plugin
-- 
2.51.0

Further information are available in Common Build Issues - Missing version increments.

Copy link
Contributor

github-actions bot commented Sep 8, 2025

Test Results

 1 947 files  ±0   1 947 suites  ±0   1h 41m 12s ⏱️ - 12m 21s
 4 720 tests ±0   4 696 ✅ ±0   24 💤 ±0  0 ❌ ±0 
14 160 runs  ±0  13 993 ✅ ±0  167 💤 ±0  0 ❌ ±0 

Results for commit 8380447. ± Comparison against base commit 80176d0.

♻️ This comment has been updated with latest results.

@SougandhS SougandhS force-pushed the ConsoleOptions branch 2 times, most recently from 45fd233 to 5675601 Compare September 15, 2025 04:41
@SougandhS
Copy link
Contributor Author

Hi @merks
Could you please check this PR when you are available ?

@laeubi
Copy link
Contributor

laeubi commented Sep 15, 2025

Also added support for customizing the format of the elapsed time, allowing users to choose from multiple display styles based on their preferences or requirements.

I would suggest to make this a text field where the user can enter any formt wanted, and simply let empty mean its disabled.

@SougandhS
Copy link
Contributor Author

I would suggest to make this a text field where the user can enter any formt wanted, and simply let empty mean its disabled.

Sure 👍

@SougandhS
Copy link
Contributor Author

the user can enter any formt wanted, and simply let empty mean its disabled.

Updated as suggested

ConsoleElapsed.mp4
image

@laeubi laeubi requested a review from merks September 16, 2025 04:35
@laeubi
Copy link
Contributor

laeubi commented Sep 16, 2025

@SougandhS thanks as the format is a bit ugly and maybe not everyone is familiar with it I would suggest that you add a litte description (e.g. a tooltip to tell what are valid I assume it has to be a java format string, but what about positional parameters?) and a preview filed that shows the result of the user input so one do not needs to start a process to see how it will look like.

As a bonus, you maybe want to have using AutoCompleteField to give the user some suggestions, or a ComboViewer with edit capability where one can choose some predefined values from the dropdown.

@SougandhS
Copy link
Contributor Author

@SougandhS thanks as the format is a bit ugly and maybe not everyone is familiar with it I would suggest that you add a litte description (e.g. a tooltip to tell what are valid I assume it has to be a java format string, but what about positional parameters?) and a preview filed that shows the result of the user input so one do not needs to start a process to see how it will look like.

As a bonus, you maybe want to have using AutoCompleteField to give the user some suggestions, or a ComboViewer with edit capability where one can choose some predefined values from the dropdown.

Sure, I'll work on this 👍

@SougandhS
Copy link
Contributor Author

I have updated as suggested

ConsoleVideo.mp4
image

@SougandhS SougandhS requested a review from laeubi September 16, 2025 12:02
@laeubi
Copy link
Contributor

laeubi commented Sep 16, 2025

@SougandhS that looks good already, but in the drowdown I would use a more human readable label for the entries like in your initial PR

@SougandhS
Copy link
Contributor Author

@SougandhS that looks good already, but in the drowdown I would use a more human readable label for the entries like in your initial PR

Will update it 👍

@SougandhS
Copy link
Contributor Author

Hi @laeubi
Updated to human readable form just like the initial PR

ConsoleH.mp4
image

@laeubi
Copy link
Contributor

laeubi commented Sep 16, 2025

Wow that's much more better now (and actually more than I suggested here), but seems much more user friendly now!

@SougandhS
Copy link
Contributor Author

@laeubi

Thank you for your suggestions :)

@SougandhS SougandhS force-pushed the ConsoleOptions branch 3 times, most recently from 177b43a to e238666 Compare September 23, 2025 11:51
This commit introduces a Combo selection in Console settings to choose
different formatting options for elapsed time shown on the console
output or disable it entirely

fixes : eclipse-platform#2112
@SougandhS
Copy link
Contributor Author

Hi @laeubi, If there are no more changes can this be merged ? Test failures are unrelated.

@laeubi laeubi merged commit 22ad862 into eclipse-platform:master Sep 24, 2025
15 of 18 checks passed
@SougandhS
Copy link
Contributor Author

Thanks a lot!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

console elapsed time format
4 participants