Fix ResourceInitialSelectionTest teardown failure #3373
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The improvement was created by Copilot cli, lets see if it can fix our long outstanding flacky test. I assume the retry should at least make this problem appear less often. |
|
Alternative implementation to #3372 which seems less inversive. |
Test Results 3 018 files ±0 3 018 suites ±0 2h 11m 55s ⏱️ - 19m 57s For more details on these failures, see this check. Results for commit 1c6578d. ± Comparison against base commit 8ce2da8. ♻️ This comment has been updated with latest results. |
The test testSingleSelectionAndOneInitialSelectionWithInitialPattern was intermittently failing with ResourceException during project deletion in doTearDown() due to background jobs holding project locks. Changes: - Add comprehensive UI event processing before/after cleanup - Wait for additional job families (FAMILY_MANUAL_REFRESH, FAMILY_AUTO_REFRESH) - Implement retry mechanism with proper NullProgressMonitor (5 retries, 1s delay) - Preserve existing exception chaining for debugging - Follow established Eclipse test patterns (ResourceHelper, ResourceActionTest) This resolves intermittent test failures in CI/CD environments where decorator and resource refresh jobs interfere with project deletion. Fixes: ResourceException: Problems encountered while deleting resources
vogella
force-pushed
the
resource_initial_selection_test_fix_flackness
branch
from
5da56c9 to
1c6578d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The test testSingleSelectionAndOneInitialSelectionWithInitialPattern was intermittently failing with ResourceException during project deletion in doTearDown() due to background jobs holding project locks.
Changes:
This resolves intermittent test failures in CI/CD environments where decorator and resource refresh jobs interfere with project deletion.
Fixes: #294