Skip to content

Fix caret of raw insert mode of text editor on HiDPI screens #3230

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Fix caret of raw insert mode of text editor on HiDPI screens #3230

wants to merge 1 commit into from

Conversation

wahlbrink
Copy link
Contributor

Fixes: #3010

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Aug 28, 2025 •
edited
Loading

Test Results

 2 904 files  + 24   2 904 suites  +24   1h 57m 49s ⏱️ + 6m 34s
 8 017 tests ±  0   7 772 ✅ ±  0  245 💤 ±0  0 ❌ ±0 
23 585 runs  +218  22 803 ✅ +217  782 💤 +1  0 ❌ ±0 

Results for commit e7aa8a3. ± Comparison against base commit 7d4cca3.

♻️ This comment has been updated with latest results.

HeikoKlare
HeikoKlare reviewed Aug 28, 2025
View reviewed changes
Copy link
Contributor

@HeikoKlare HeikoKlare left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for proposing this fix! I have one question regarding the proposed solution, as it appears more complex to me than required.

...es/org.eclipse.ui.workbench.texteditor/src/org/eclipse/ui/texteditor/AbstractTextEditor.java

return bracketImage;
int height= styledText.getLineHeight();
return new Image(styledText.getDisplay(), new ImageDataProvider() {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there any reason to use an ImageDataProvider rather than an ImageGcDrawer?
This requires to manually implement proper line width calculation and line rendering instead of just using gc.drawLine() like in the original code.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This creates a 1-bit image as before.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What do you mean with "1-bit image"? Do you mean that the line is 1 pixel wide? That's the intended behavior of setLineWidth(0). Changing that to setLineWidth(1) should resolve it.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

1-bit image = image with 1-bit color palette = a pixels uses 1-bit = colloquially called black-and-white image

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see. But is it really necessary/beneficial to keep it like that?

@HeikoKlare HeikoKlare mentioned this pull request Aug 28, 2025
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@HeikoKlare HeikoKlare HeikoKlare left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Ctrl+Shift+Insert in Eclipse key bindings doesn't show insert caret when monitor zoom ≠ 100%
2 participants
@wahlbrink @HeikoKlare