Skip to content

Conversation

N1k145
Copy link
Contributor

@N1k145 N1k145 commented Sep 12, 2024

The Idea is that currently it is not possible to modify a project when it is copied and renamed. This leads to usability issues for example in PDE, where the rename of a project modifies the MANIFEST.MF but a copy does not. This solves this by providing a copy project refactoring that can be extended using a copy participant.

This is related to #2155

Copy link
Contributor

github-actions bot commented Sep 12, 2024

Test Results

 1 802 files  +  588   1 802 suites  +588   2h 0m 40s ⏱️ + 1h 4m 48s
 7 726 tests +    1   7 497 ✅ ±    0  228 💤 ±  0  1 ❌ +1 
23 980 runs  +7 756  23 238 ✅ +7 481  741 💤 +274  1 ❌ +1 

For more details on these failures, see this check.

Results for commit 3786445. ± Comparison against base commit 7aaa014.

♻️ This comment has been updated with latest results.

@N1k145 N1k145 force-pushed the copyProjectWithLTK-2155 branch from e222d9f to d619d9e Compare September 12, 2024 05:33
@N1k145 N1k145 force-pushed the copyProjectWithLTK-2155 branch 4 times, most recently from f73dc58 to 4acc07e Compare September 20, 2024 10:44
@N1k145 N1k145 marked this pull request as ready for review September 20, 2024 13:30
@N1k145 N1k145 force-pushed the copyProjectWithLTK-2155 branch 3 times, most recently from 512ca60 to 559e7bd Compare September 25, 2024 05:11
@N1k145 N1k145 force-pushed the copyProjectWithLTK-2155 branch from 559e7bd to ce12744 Compare September 30, 2024 12:57
@mickaelistria mickaelistria added this to the 4.35 M1 milestone Nov 25, 2024
The Idea is that currently it is not possible to modify a project when it is copied and renamed. This leads to usability issues for example in PDE, where the rename of a project modifies the MANIFEST.MF but a copy does not.
This solves this by providing a copy project refactoring that can be extended using a copy participant.
@N1k145 N1k145 force-pushed the copyProjectWithLTK-2155 branch from ce12744 to 9ebcb2a Compare November 25, 2024 15:07
@eclipse-platform-bot
Copy link
Contributor

This pull request changes some projects for the first time in this development cycle.
Therefore the following files need a version increment:

bundles/org.eclipse.ui.ide/META-INF/MANIFEST.MF

An additional commit containing all the necessary changes was pushed to the top of this PR's branch. To obtain these changes (for example if you want to push more changes) either fetch from your fork or apply the git patch.

Git patch
From a69ab9a714a31ae419e53a1fd5e5797e91041fec Mon Sep 17 00:00:00 2001
From: Eclipse Platform Bot <platform-bot@eclipse.org>
Date: Mon, 25 Nov 2024 15:12:07 +0000
Subject: [PATCH] Version bump(s) for 4.35 stream


diff --git a/bundles/org.eclipse.ui.ide/META-INF/MANIFEST.MF b/bundles/org.eclipse.ui.ide/META-INF/MANIFEST.MF
index c43ddcf24b..29956309a3 100644
--- a/bundles/org.eclipse.ui.ide/META-INF/MANIFEST.MF
+++ b/bundles/org.eclipse.ui.ide/META-INF/MANIFEST.MF
@@ -2,7 +2,7 @@ Manifest-Version: 1.0
 Bundle-ManifestVersion: 2
 Bundle-Name: %Plugin.name
 Bundle-SymbolicName: org.eclipse.ui.ide; singleton:=true
-Bundle-Version: 3.22.400.qualifier
+Bundle-Version: 3.22.500.qualifier
 Bundle-Activator: org.eclipse.ui.internal.ide.IDEWorkbenchPlugin
 Bundle-ActivationPolicy: lazy
 Bundle-Vendor: %Plugin.providerName
-- 
2.47.0

Further information are available in Common Build Issues - Missing version increments.

@mickaelistria mickaelistria merged commit 6a3eb35 into eclipse-platform:master Nov 26, 2024
14 of 17 checks passed
@N1k145
Copy link
Contributor Author

N1k145 commented Nov 26, 2024

@mickaelistria thank you very much for merging

@mickaelistria
Copy link
Contributor

thank you very much for merging

Thank you for the patch!
Please keep actively looking at reported issues for a few weeks to detect potential related issues.

@jukzi
Copy link
Contributor

jukzi commented Jan 15, 2025

This PR introduced several new warnings in the workspace. can you please fix them?
image

@mickaelistria
Copy link
Contributor

I think the plugin.properties was missing in the commit.

@N1k145
Copy link
Contributor Author

N1k145 commented Jan 15, 2025

@jukzi @mickaelistria thank you for noticing, I will look into it directly...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants