Skip to content

DPI_CHANGED rough performance analysis #2233

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from
Draft

DPI_CHANGED rough performance analysis #2233

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions bundles/org.eclipse.swt/Eclipse SWT/win32/org/eclipse/swt/widgets/Composite.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1063,6 +1063,9 @@ void setBoundsInPixels (int x, int y, int width, int height, int flags, boolean
state &= ~(RESIZE_OCCURRED | MOVE_OCCURRED);
state |= RESIZE_DEFERRED | MOVE_DEFERRED;
}
if (x == this.x && this.y == y && this.width == width && this.height == height && this.flags == flags) {
return;
}
super.setBoundsInPixels (x, y, width, height, flags, defer);
if (!defer && (state & CANVAS) != 0) {
boolean wasMoved = (state & MOVE_OCCURRED) != 0;
Expand Down
12 changes: 11 additions & 1 deletion bundles/org.eclipse.swt/Eclipse SWT/win32/org/eclipse/swt/widgets/Control.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3193,6 +3193,11 @@ void setBoundsInPixels (int x, int y, int width, int height, int flags) {
}

void setBoundsInPixels (int x, int y, int width, int height, int flags, boolean defer) {
long lol = topHandle ();
if(x == this.x && this.y == y && this.width == width && this.height == height && this.flags == flags) {
// System.out.println("yo " + lol);
return;
}
if (findImageControl () != null) {
if (backgroundImage == null) flags |= OS.SWP_NOCOPYBITS;
} else {
Expand All @@ -3202,7 +3207,8 @@ void setBoundsInPixels (int x, int y, int width, int height, int flags, boolean
}
}
}
long topHandle = topHandle ();
long topHandle = lol;
// System.out.println(topHandle);
if (defer && parent != null) {
forceResize ();
if (parent.lpwp != null) {
Expand All @@ -3229,8 +3235,12 @@ void setBoundsInPixels (int x, int y, int width, int height, int flags, boolean
}
}
OS.SetWindowPos (topHandle, 0, x, y, width, height, flags);
this.x = x;
this.y = y;this.width = width; this.height = height; this.flags = flags;
}

int x, y, width, height, flags;

/**
* Sets the receiver's size and location in points to the rectangular
* area specified by the argument. The <code>x</code> and
Expand Down
Loading