Amartya4256/c tab folder fix float aware #2211
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Test Results104 files - 441 104 suites - 441 4s ⏱️ - 34m 5s For more details on these failures, see this check. Results for commit fd97443. ± Comparison against base commit 0a68dea. This pull request removes 4333 tests.♻️ This comment has been updated with latest results. |
This commit moves the classes MonitorAwareRectangle and MonitorAwarePoint to Rectangle and Point as a static class and renames them to WithMonitor to allow them to be used as Rectangle.WithMonitor and Point.WithMonitor. contributes to eclipse-platform#62 and eclipse-platform#128
amartya4256
force-pushed
the
amartya4256/CTabFolder_fix_float_aware
branch
from
8cedf34 to
2a34655
Compare
This commit introduces Rectangle.OfFloat and Point.OfFloat classes as an extension of Rectangle and Point respectively to improve scaling precision in the DPIUtil by using residuals obtained from rounding. Contributes to eclipse-platform#62 and eclipse-platform#128
amartya4256
force-pushed
the
amartya4256/CTabFolder_fix_float_aware
branch
from
2a34655 to
fd97443
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is to show that properly utilizing the float aware residuals indeed fixes the border issue of CTabFolder. We need a cleaner approach for this.