Skip to content

Configure SWT build scripts for 4.37 #2193

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 3, 2025

Conversation

MohananRahul
Copy link
Contributor

Copy link
Contributor

github-actions bot commented Jun 2, 2025

Test Results

104 files  ±0  104 suites  ±0   5s ⏱️ -1s
 66 tests ±0   66 ✅ ±0  0 💤 ±0  0 ❌ ±0 
213 runs  ±0  213 ✅ ±0  0 💤 ±0  0 ❌ ±0 

Results for commit 3e28797. ± Comparison against base commit 55e9110.

♻️ This comment has been updated with latest results.

@MohananRahul
Copy link
Contributor Author

MohananRahul commented Jun 2, 2025

@HannesWell , Please review. Created a PR in the absence of @deepika-u by referring to issue #1873

@akurtakov
Copy link
Member

https://ci.eclipse.org/releng/computer/riscv%2Dbuild1/ fails to launch and this would prevent pushing rebuild natives. Please open a helpdesk ticket to resolve that before pushing.

@MohananRahul
Copy link
Contributor Author

https://ci.eclipse.org/releng/computer/riscv%2Dbuild1/ fails to launch and this would prevent pushing rebuild natives. Please open a helpdesk ticket to resolve that before pushing.

https://gitlab.eclipse.org/eclipsefdn/helpdesk/-/issues/6217

@MohananRahul
Copy link
Contributor Author

https://ci.eclipse.org/releng/computer/riscv%2Dbuild1/ fails to launch and this would prevent pushing rebuild natives. Please open a helpdesk ticket to resolve that before pushing.

Now it is pushed.

@akurtakov akurtakov merged commit a3174e7 into eclipse-platform:master Jun 3, 2025
20 of 25 checks passed
@MohananRahul MohananRahul deleted the F2192 branch June 3, 2025 14:41
@iloveeclipse
Copy link
Member

See eclipse-platform/eclipse.platform.releng.aggregator#3070 (comment)

Do we miss some native job execution to get SWT binaries built properly?

@akurtakov
Copy link
Member

@akurtakov
Copy link
Member

Authentication error: Authentication required: You must have push access to verify locks is not helping as it fails in the same way for #2196 . At the same time equinox one works eclipse-equinox/equinox#1005 and my fork has the same default fork permissions.

@iloveeclipse
Copy link
Member

Stupid questions:

  1. how the github action result affects SWT natives rebuild on Jenkins? Or don't we need Jenkins?
  2. how to get from the workflow run to the PR that triggered it?

@akurtakov
Copy link
Member

  1. GHAs do the automatic version bumps and add extra commits with that to the PR.
  2. Crawl through the logs in https://github.com/eclipse-platform/eclipse.platform.swt/actions is what I do.

@iloveeclipse
Copy link
Member

GHAs do the automatic version bumps and add extra commits with that to the PR.

Should we manually bump versions if GH can't do that for whatever reason?

Crawl through the logs in https://github.com/eclipse-platform/eclipse.platform.swt/actions is what I do.

I didn't get it, sorry. I see number of actions not obviously connected to anything pointing to a PR.

@akurtakov
Copy link
Member

GHAs do the automatic version bumps and add extra commits with that to the PR.

Should we manually bump versions if GH can't do that for whatever reason?

No, we should give some time for people to look into why the automation fails and get it fixed.

Crawl through the logs in https://github.com/eclipse-platform/eclipse.platform.swt/actions is what I do.

I didn't get it, sorry. I see number of actions not obviously connected to anything pointing to a PR.

@HeikoKlare
Copy link
Contributor

Such push errors can also occur if there are LFS changes to be pushed, as that's not possible for maintainers even if edits are allowed for a PR. That's something you experience especially in SWT when adapting a PR of someone else and rebasing on top of master when there has been a natives build in between, as you cannot push the changed LFS artifacts then. You first have to rebase the PR via GitHub and then apply your changes.
However, in this case there is obviously no change to LFS artifacts in what the bot tries to push, but still wanted to mention it in case there is something not that obvious happening.

@HannesWell
Copy link
Member

GHAs do the automatic version bumps and add extra commits with that to the PR.

Should we manually bump versions if GH can't do that for whatever reason?

No, we should give some time for people to look into why the automation fails and get it fixed.

I'm currently looking into it (also with my own PR).

@HannesWell
Copy link
Member

Authentication error: Authentication required: You must have push access to verify locks is not helping as it fails in the same way for #2196 . At the same time equinox one works eclipse-equinox/equinox#1005 and my fork has the same default fork permissions.

I was now able to reproduce this in

I'm not yet sure if the permissions of the bot-token have somehow been reduced or if this is because of the special nature of the SWT repo as Heiko indicated.
At least I was able to workaround it by pushing directly into this repo:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants