Skip to content

Deactivate toggling test for the Edge browser #2112

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

fedejeanne
Copy link
Contributor

Until it's fixed, the test shall remain deactivated.

In response to: #2106 (comment) (@akurtakov )

Copy link
Contributor

github-actions bot commented May 7, 2025

Test Results

   539 files   -  6     539 suites   - 6   32m 10s ⏱️ + 1m 20s
 4 339 tests  - 37   4 323 ✅  - 35   15 💤  - 3  1 ❌ +1 
16 606 runs   - 37  16 467 ✅  - 36  138 💤  - 2  1 ❌ +1 

For more details on these failures, see this check.

Results for commit 41d86c9. ± Comparison against base commit a1d0720.

This pull request removes 37 tests.
AllWin32Tests org.eclipse.swt.graphics.ImageWin32Tests ‑ testImageDataForDifferentFractionalZoomsShouldBeDifferent
AllWin32Tests org.eclipse.swt.graphics.ImageWin32Tests ‑ testImageShouldHaveDimesionAsPerZoomLevel
AllWin32Tests org.eclipse.swt.tests.win32.Test_org_eclipse_swt_dnd_DND ‑ testByteArrayTransfer
AllWin32Tests org.eclipse.swt.tests.win32.Test_org_eclipse_swt_dnd_DND ‑ testFileTransfer
AllWin32Tests org.eclipse.swt.tests.win32.Test_org_eclipse_swt_dnd_DND ‑ testHtmlTransfer
AllWin32Tests org.eclipse.swt.tests.win32.Test_org_eclipse_swt_dnd_DND ‑ testImageTransfer_fromCopiedImage
AllWin32Tests org.eclipse.swt.tests.win32.Test_org_eclipse_swt_dnd_DND ‑ testImageTransfer_fromImage
AllWin32Tests org.eclipse.swt.tests.win32.Test_org_eclipse_swt_dnd_DND ‑ testImageTransfer_fromImageData
AllWin32Tests org.eclipse.swt.tests.win32.Test_org_eclipse_swt_dnd_DND ‑ testImageTransfer_fromImageDataFromImage
AllWin32Tests org.eclipse.swt.tests.win32.Test_org_eclipse_swt_dnd_DND ‑ testRtfTransfer
…

@fedejeanne
Copy link
Contributor Author

Failing test has been documented #2113

@fedejeanne fedejeanne merged commit b42b7ff into eclipse-platform:master May 7, 2025
8 of 12 checks passed
@fedejeanne fedejeanne deleted the deactivate_dom_test_edge branch May 7, 2025 07:23
@HeikoKlare
Copy link
Contributor

Please do not merge PRs without a Jenkins run. Even though this will PR probably not introduce any issues revealed by Jenkins build, there is no need to urge with merging without waiting for the Jenkins run.

@fedejeanne
Copy link
Contributor Author

Please do not merge PRs without a Jenkins run. Even though this will PR probably not introduce any issues revealed by Jenkins build, there is no need to urge with merging without waiting for the Jenkins run.

Oh, I missed the yellow dot and only saw the green ones, sorry.

@HeikoKlare
Copy link
Contributor

Jenkins build always starts only after a PR has been marked as ready for review, so marking a PR as ready for review and merging immediately afterwards is never possible without ignoring Jenkins results.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants