Build GTK 4 binaries #1422

laeubi · 2024-08-27T08:53:02Z

Currently the GTK4 binaries are not build as part of the build, this has several drawbacks:

If anything is adjusted for GTK4 part it might break without notice 2) We have no GTK4 binaries by default

This enables compilation of the gtk4 parts to see at least everything can be compiled.

The following has to be checked:

do we have everything to compile for Jenkins Pod
do we have everything to compile for Github
...

github-actions · 2024-08-27T09:03:23Z

Test Results

483 files ±0 483 suites ±0 7m 46s ⏱️ -51s
4 095 tests ±0 4 085 ✅ ±0 7 💤 ±0 3 ❌ ±0
16 173 runs ±0 16 080 ✅ ±0 90 💤 ±0 3 ❌ ±0

For more details on these failures, see this check.

Results for commit 9da5b34. ± Comparison against base commit ca1bb19.

♻️ This comment has been updated with latest results.

bundles/org.eclipse.swt/Eclipse SWT PI/gtk/library/gtk3.h

laeubi · 2024-08-27T09:37:42Z

Now Github succeed and Jenkins fails as expected:

11:31:19  gcc -shared -fPIC  -s -o libswt-cairo-gtk-4966r6.so swt.o cairo.o cairo_structs.o cairo_stats.o `pkg-config --libs-only-L cairo` -lcairo

11:31:19  gcc -O -Wall -fPIC -DSWT_VERSION=4966r6   -DLINUX -DGTK -I/home/jenkins/agent/workspace/eclipse.platform.swt_PR-1422/jdk.resources/include -I/home/jenkins/agent/workspace/eclipse.platform.swt_PR-1422/jdk.resources/include/linux -DJNI64 -Werror   -c -o swt_awt.o swt_awt.c

11:31:19  gcc -shared   -s -o libswt-awt-gtk-4966r6.so swt_awt.o -L/home/jenkins/agent/workspace/eclipse.platform.swt_PR-1422/jdk.resources/lib -ljawt

11:31:19  cp libswt-gtk-4966r6.so libswt-awt-gtk-4966r6.so libswt-pi3-gtk-4966r6.so libswt-cairo-gtk-4966r6.so libswt-atk-gtk-4966r6.so libswt-glx-gtk-4966r6.so libswt-webkit-gtk-4966r6.so /home/jenkins/agent/workspace/eclipse.platform.swt_PR-1422/libs

11:31:19  
GTK3 Build succeeded

11:31:19  
Note: When building multiple GTK versions, a cleanup is required (and automatically performed) between them.

11:31:19  
Cleaning up...

11:31:19  rm -f *.o *.so

11:31:19  
Building GTK4 bindings:

11:31:19  gcc -O -Wall -fPIC -DSWT_VERSION=4966r6   -DLINUX -DGTK -I/home/jenkins/agent/workspace/eclipse.platform.swt_PR-1422/jdk.resources/include -I/home/jenkins/agent/workspace/eclipse.platform.swt_PR-1422/jdk.resources/include/linux -DJNI64 -Werror -c swt.c

11:31:19  gcc -O -Wall -fPIC -DSWT_VERSION=4966r6   -DLINUX -DGTK -I/home/jenkins/agent/workspace/eclipse.platform.swt_PR-1422/jdk.resources/include -I/home/jenkins/agent/workspace/eclipse.platform.swt_PR-1422/jdk.resources/include/linux -DJNI64 -Werror   -c -o c.o c.c

11:31:19  gcc -O -Wall -fPIC -DSWT_VERSION=4966r6   -DLINUX -DGTK -I/home/jenkins/agent/workspace/eclipse.platform.swt_PR-1422/jdk.resources/include -I/home/jenkins/agent/workspace/eclipse.platform.swt_PR-1422/jdk.resources/include/linux -DJNI64 -Werror   -c -o c_stats.o c_stats.c

11:31:19  gcc -O -Wall -fPIC -DSWT_VERSION=4966r6   -DLINUX -DGTK -I/home/jenkins/agent/workspace/eclipse.platform.swt_PR-1422/jdk.resources/include -I/home/jenkins/agent/workspace/eclipse.platform.swt_PR-1422/jdk.resources/include/linux -DJNI64 -Werror `pkg-config --cflags gtk4 gtk4-x11 gtk4-unix-print` -DUSE_ASSEMBLER -c callback.c

11:31:19  Package gtk4 was not found in the pkg-config search path.

11:31:19  Perhaps you should add the directory containing `gtk4.pc'

11:31:19  to the PKG_CONFIG_PATH environment variable

11:31:19  Package 'gtk4', required by 'virtual:world', not found

11:31:19  Package 'gtk4-x11', required by 'virtual:world', not found

11:31:19  Package 'gtk4-unix-print', required by 'virtual:world', not found

11:31:23  gcc -shared -fPIC  -s -o libswt-gtk-4966r6.so swt.o c.o c_stats.o callback.o

11:31:23  gcc -O -Wall -fPIC -DSWT_VERSION=4966r6   -DLINUX -DGTK -I/home/jenkins/agent/workspace/eclipse.platform.swt_PR-1422/jdk.resources/include -I/home/jenkins/agent/workspace/eclipse.platform.swt_PR-1422/jdk.resources/include/linux -DJNI64 -Werror `pkg-config --cflags gtk4 gtk4-x11 gtk4-unix-print` -c os.c

11:31:23  Package gtk4 was not found in the pkg-config search path.

11:31:23  Perhaps you should add the directory containing `gtk4.pc'

11:31:23  to the PKG_CONFIG_PATH environment variable

11:31:23  Package 'gtk4', required by 'virtual:world', not found

11:31:23  Package 'gtk4-x11', required by 'virtual:world', not found

11:31:23  Package 'gtk4-unix-print', required by 'virtual:world', not found

11:31:23  In file included from os_structs.h:19,

11:31:23                   from os.c:20:

11:31:23  os.h:30:10: fatal error: gtk/gtk.h: No such file or directory

11:31:23   #include <gtk/gtk.h>

11:31:23            ^~~~~~~~~~~

11:31:23  compilation terminated.

11:31:23  make: *** [make_linux.mak:144: os.o] Error 1

11:31:23  
*** GTK4 Build failed, aborting further actions..

ptziegler · 2024-08-27T19:37:44Z

Given that I wanted to have a look at some of those deprecation errors in the near future, what version of GTK4 do you plan on compiling against?

With #1421, SWT would require at least require 4.10 but then the build would have to continue despite the deprecations. With older versions, the build would succeed but then the PR no longer builds as the new methods don't exist yet.

akurtakov · 2024-08-28T05:25:37Z

As GTK4 is WIP it should be fine to require as new version as needed . By the time this is ready for prime time that version would have made it to mainstream distros.

laeubi · 2024-08-28T06:05:40Z

Main goal is to build it with "what is available right now", if we have this working one can go step further to support a specific version. But still then one need to take care as using "the latest" might simply make it impossible for some linux distributions (e.g LTE) that not always have latest and greatest of libraries, but "latest stable" version.

laeubi · 2024-08-28T07:37:39Z

Even though GTK4 was added here:

https://github.com/eclipse-platform/eclipse.platform.releng.aggregator/pull/2259/files

and container build seem to have completed

https://ci.eclipse.org/releng/view/Miscellaneous/job/Build-Docker-images/732/

the build still complains:

Package gtk4 was not found in the pkg-config search path.

@fredg02 anything else that needs to be done so the new container is visible? Can we do anything to verify the change is actually used? I didn't find anything in the log that indicates the actual used container has/version/date/....

iloveeclipse · 2024-08-28T07:45:05Z

Main goal is to build it with "what is available right now", if we have this working one can go step further to support a specific version.

We should have target Linux versions specified in the project plan, similar to Java versions.

RHEL 9
SUSE 15 SP4
Ubuntu 24.04
The minimal GTK4 version could be derived from there.

akurtakov · 2024-08-28T08:11:19Z

Main goal is to build it with "what is available right now", if we have this working one can go step further to support a specific version.

We should have target Linux versions specified in the project plan, similar to Java versions.
* RHEL 9

* SUSE 15 SP4

* Ubuntu 24.04
  The minimal GTK4 version could be derived from there.

I would agree with such version targeting when we discuss making GTK 4 default one. Unfortunately we are very far from it so by the time this discussion comes we will most likely have RHEL 10(most likely 11) and Ubuntu 26.04.
Speaking from history - when port to GTK 3 was done we had to give feedback to gtk developers, report bugs, test patches and several times target even development versions in order to manage to complete SWT on GTK3 port. Setting targets based on what current LTS distros ships will most likely make the port far more harder than it should be (and some SWT features even impossible).

akurtakov · 2024-08-28T08:13:25Z

One such impossible feature on RHEL 9 would be Browser support as even though there is gtk4 there is no webkitgtk4.

laeubi · 2024-08-28T08:38:57Z

That's why I said lets first get something compiled, then its easier to iterate, I tried to add some commands to find out actual installed versions for the github runners it is this versions:

libgtk-3-0/jammy-updates,jammy-security,now 3.24.33-1ubuntu2.2 amd64 [installed]
libgtk-3-common/jammy-updates,jammy-security,now 3.24.33-1ubuntu2.2 all [installed,automatic]
libgtk-3-dev/jammy-updates,jammy-security,now 3.24.33-1ubuntu2.2 amd64 [installed]
libgtk-4-1/jammy-updates,jammy-security,now 4.6.9+ds-0ubuntu0.22.04.2 amd64 [installed,automatic]
libgtk-4-bin/jammy-updates,jammy-security,now 4.6.9+ds-0ubuntu0.22.04.2 amd64 [installed,automatic]
libgtk-4-common/jammy-updates,jammy-security,now 4.6.9+ds-0ubuntu0.22.04.2 all [installed,automatic]
libgtk-4-dev/jammy-updates,jammy-security,now 4.6.9+ds-0ubuntu0.22.04.2 amd64 [installed]

laeubi · 2024-08-28T09:06:22Z

Jenkins CentOS currently using

gtk3-devel-3.22.30-11.el8.aarch64
webkit2gtk3-jsc-2.38.5-1.el8.aarch64
webkit2gtk3-2.38.5-1.el8.aarch64
gtk-update-icon-cache-3.22.30-11.el8.aarch64
webkit2gtk3-jsc-devel-2.38.5-1.el8.aarch64
gtk2-2.24.32-5.el8.aarch64
gtk2-devel-2.24.32-5.el8.aarch64
gtk3-3.22.30-11.el8.aarch64
libcanberra-gtk3-0.30-18.el8.aarch64
webkit2gtk3-devel-2.38.5-1.el8.aarch64

so it seems docker file change has had no effect...

fredg02 · 2024-08-28T09:13:25Z

so it seems docker file change has had no effect...

https://ci.eclipse.org/releng/view/Miscellaneous/job/Build-Docker-images builds docker images from https://github.com/eclipse-platform/eclipse.platform.releng.aggregator/tree/master/cje-production/dockerfiles. I don't know if there is a Jenkins job that actually builds https://github.com/eclipse-platform/eclipse.platform.swt/tree/master/container.

I'd recommend to talk to project members that know more about the platform/swt docker builds. This should be more effective than you or me trying to decipher the inner workings of platform releng builds.

I would also recommend to not use a matrix build while trying to get this running. It makes debugging harder than it should be.

fredg02 · 2024-08-28T09:17:32Z

When you have found the right job to build the right docker image, I'd verify that it includes everything that is needed by running it locally. Once that is done, you can specify the sha256 of the image in your Jenkinsfile to make sure that the exact image is pulled.

akurtakov · 2024-08-28T09:36:36Z

@fredg02 So according to https://ci.eclipse.org/releng/job/Build-Docker-images/732/artifact/eclipse.platform.releng.aggregator/cje-production/dockerfiles/swt_9_build.log and https://ci.eclipse.org/releng/job/Build-Docker-images/732/artifact/eclipse.platform.releng.aggregator/cje-production/dockerfiles/push-swt_9_build.log image should be built and pushed but looking at https://hub.docker.com/layers/eclipse/platformreleng-centos-swt-build/9/images/sha256-31294c0be3473791b82c8f6cbb9e9e1bf5ff42701553eed6a5e17f5f427c59e4?context=explore image was last updated 2 months ago. I have no idea how to help more here.

fredg02 · 2024-08-28T09:45:03Z

As noted above, https://ci.eclipse.org/releng/job/Build-Docker-images/ is not building the Dockerfile that @laeubi modified.

laeubi · 2024-08-28T09:49:26Z

@fredg02

I changed the file here:

Add gtk4-devel to centos-9 for swt and remove gtk2 eclipse.platform.releng.aggregator#2259

And Jenkins config says it runs build-centos_9_swt_build.sh what includes:

set -e

pushd centos-gtk4-mutter/9-swtBuild
echo "Building Centos 9 swt build image"
docker build --pull -t eclipse/platformreleng-centos-swt-build:9 .
popd

do I miss something obvious?

laeubi · 2024-08-28T09:52:26Z

@sravanlakkimsetti can you maybe shade some light here, the Jenkins file config and collection of shellscripts seems not easy to understand :-\

I even wonder if it would not be easier to have one Jeankinsfile (in git) that includes the shell calls directly instead of many different shell scripts with only a few line in it.

fredg02 · 2024-08-28T10:13:07Z

@fredg02
I changed the file here:
eclipse-platform/eclipse.platform.releng.aggregator#2259

Ok. That was not obvious to me, based on the comments here.

laeubi · 2024-08-28T17:56:35Z

Finally the docker images was updated and now we have GTK4 at the build node, this is the used GTK version and it shows a lot of deprecation warnings:

19:52:21  Name        : gtk4-devel
19:52:21  Version     : 4.12.3
19:52:21  Release     : 2.el9
19:52:21  Architecture: x86_64
19:52:21  Install Date: Wed 28 Aug 2024 05:27:02 PM UTC
19:52:21  Group       : Unspecified
19:52:21  Size        : 13102429
19:52:21  License     : LGPL-2.0-or-later
19:52:21  Signature   : RSA/SHA256, Mon 18 Dec 2023 09:49:21 PM UTC, Key ID 05b555b38483c65d
19:52:21  Source RPM  : gtk4-4.12.3-2.el9.src.rpm
19:52:21  Build Date  : Fri 08 Dec 2023 12:37:08 PM UTC
19:52:21  Build Host  : x86-04.stream.rdu2.redhat.com
19:52:21  Packager    : builder@centos.org
19:52:21  Vendor      : CentOS
19:52:21  URL         : https://www.gtk.org
19:52:21  Summary     : Development files for GTK

See https://ci.eclipse.org/releng/job/eclipse.platform.swt/job/PR-1422/14/pipeline-console/?selected-node=195
https://ci.eclipse.org/releng/job/eclipse.platform.swt/job/PR-1422/14/pipeline-console/log?nodeId=501

laeubi · 2024-11-12T09:22:28Z

This is now ready to be merged once master is open for the next stream.

mickaelistria · 2024-11-12T10:21:07Z

If we can audit that this change doesn't modify any of the already built artifacts (only adds new ones) and that the behavior seems backward compatible; then could we consider a merge ASAP, before next stream starts even?
@laeubi are those assumptions supposed to hold true?
@akurtakov What do you think?

laeubi · 2024-11-12T10:23:03Z

This will at least raise the GLIBC version requirements and therefore might not be good in current release phase.

akurtakov · 2024-11-12T10:24:50Z

@mickaelistria This has been already tested and building on newer distros leads to using newer glibc symbols (versioned dlsym/dlopen IIRC) that render old systems no longer loading. So it's best to delay till start of next cycle.

Jenkinsfile

laeubi · 2024-11-27T08:35:34Z

Now the native build succeeds but for some reason the text execution failed in the initialize shell.

laeubi · 2024-11-27T08:36:57Z

I think the problem is that SWT still uses centos-latest pod:

eclipse.platform.swt/Jenkinsfile

Line 87 in 6ab4ccd

label 'centos-latest'

akurtakov · 2024-11-27T08:38:26Z

From the log:

version `GLIBC_2.34' not found (required by /home/jenkins/agent/workspace/eclipse.platform.swt_PR-1422/eclipse.platform.swt/tests/org.eclipse.swt.tests/target/.swt/lib/linux/x86_64/libswt-pi3-gtk-4967r9.so)

Please move to some newer image. Maybe in separate PR and rebase this one on top of it so we deliver that part now independent of gtk4.

laeubi · 2024-11-27T08:40:30Z

I have created

Use ubuntu-latest instead of outdated centos-8 #1624

Currently the GTK4 binaries are not build as part of the build, this has several drawbacks: 1) If anything is adjusted for GTK4 part it might break without notice 2) We have no GTK4 binaries by default This enables *compilation* of the gtk4 parts to see at least everything can be compiled.

chirontt · 2024-12-01T01:34:53Z

@laeubi
Using the latest of master branch, I try to (re)build the SWT natives for Linux x86_64, on my box with Ubuntu 2404, I get tons of deprecation warnings when compiling for GTK4, and the compile then fails due to the -Werror compile option turned on for both GTK 3 & 4 versions:

eclipse.platform.swt/bundles/org.eclipse.swt/Eclipse SWT PI/gtk/library/make_linux.mak

Line 114 in cfa74b4

CFLAGS += -Werror

To get around the above compile failure for GTK4, I need to turn off the -Werror flag for GTK4, like:

ifeq ($(GTK_VERSION), 3.0)
CFLAGS += -Werror
endif

Do you want me to submit a PR for the above change?

chirontt · 2024-12-01T01:45:30Z

FYI: here are the manual commands I use to (re)build the SWT natives for Linux x86_64 on my Ubuntu box:

cd binaries/org.eclipse.swt.gtk.linux.x86_64
mvn clean process-resources -Dnative=gtk.linux.x86_64

laeubi · 2024-12-01T05:24:56Z

@chirontt I think the goal is more to resolve these warnings (@sratz has recently working on these) so any help is welcome.

In the meantime you mentioned workaround seems suitable for local compilation and we probably should mention this in the developer docs.

The image 'platformreleng-centos-swt-build:8' cannot be built anymore and is therefore not updated. Align with SWT and use the debian-12 image instead. This will increase the GLIBC version requirement to version 2.34, see eclipse-platform/eclipse.platform.swt#1422 (comment) See also eclipse-platform/eclipse.platform.releng.aggregator#2441

This comment was marked as outdated.

Sign in to view

laeubi force-pushed the build_gtk4 branch from bb0e58c to 8550290 Compare August 27, 2024 09:28

laeubi commented Aug 27, 2024

View reviewed changes

bundles/org.eclipse.swt/Eclipse SWT PI/gtk/library/gtk3.h Outdated Show resolved Hide resolved

laeubi force-pushed the build_gtk4 branch 3 times, most recently from e447b1c to 397da2e Compare August 27, 2024 11:33

laeubi force-pushed the build_gtk4 branch from 397da2e to e588c3f Compare August 28, 2024 07:59

laeubi force-pushed the build_gtk4 branch from e588c3f to 995cee5 Compare August 28, 2024 08:30

laeubi force-pushed the build_gtk4 branch 3 times, most recently from ec1b98b to 60dc09c Compare August 28, 2024 08:48

laeubi force-pushed the build_gtk4 branch 4 times, most recently from 0be5151 to 6c6e672 Compare November 12, 2024 09:21

laeubi marked this pull request as ready for review November 12, 2024 09:22

laeubi force-pushed the build_gtk4 branch from 6c6e672 to 70f9b85 Compare November 13, 2024 10:31

HannesWell reviewed Nov 24, 2024

View reviewed changes

Jenkinsfile Outdated Show resolved Hide resolved

laeubi force-pushed the build_gtk4 branch 4 times, most recently from 21fa88d to 3573d46 Compare November 27, 2024 07:54

laeubi force-pushed the build_gtk4 branch from 3573d46 to 9da5b34 Compare November 27, 2024 10:46

laeubi merged commit c984d14 into eclipse-platform:master Nov 27, 2024
8 of 14 checks passed

akurtakov mentioned this pull request Dec 2, 2024

[Linux] SDK fails to start on RHEL 7.9 since I20241127-1240, requires GLIBC_2.34 #1631

Closed

HannesWell mentioned this pull request Dec 15, 2024

Build Equinox launcher for linux.x86_64 on debian-12 eclipse-equinox/equinox#722

Merged

Build GTK 4 binaries #1422

Build GTK 4 binaries #1422

Uh oh!

Conversation

laeubi commented Aug 27, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions bot commented Aug 27, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Test Results

Uh oh!

This comment was marked as outdated.

Uh oh!

laeubi commented Aug 27, 2024

Uh oh!

ptziegler commented Aug 27, 2024

Uh oh!

akurtakov commented Aug 28, 2024

Uh oh!

laeubi commented Aug 28, 2024

Uh oh!

laeubi commented Aug 28, 2024

Uh oh!

iloveeclipse commented Aug 28, 2024

Uh oh!

akurtakov commented Aug 28, 2024

Uh oh!

akurtakov commented Aug 28, 2024

Uh oh!

laeubi commented Aug 28, 2024

Uh oh!

laeubi commented Aug 28, 2024

Uh oh!

fredg02 commented Aug 28, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

fredg02 commented Aug 28, 2024

Uh oh!

akurtakov commented Aug 28, 2024

Uh oh!

fredg02 commented Aug 28, 2024

Uh oh!

laeubi commented Aug 28, 2024

Uh oh!

laeubi commented Aug 28, 2024

Uh oh!

fredg02 commented Aug 28, 2024

Uh oh!

laeubi commented Aug 28, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

laeubi commented Nov 12, 2024

Uh oh!

mickaelistria commented Nov 12, 2024

Uh oh!

laeubi commented Nov 12, 2024

Uh oh!

akurtakov commented Nov 12, 2024

Uh oh!

Uh oh!

laeubi commented Nov 27, 2024

Uh oh!

laeubi commented Nov 27, 2024

Uh oh!

akurtakov commented Nov 27, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

laeubi commented Nov 27, 2024

Uh oh!

Uh oh!

chirontt commented Dec 1, 2024

Uh oh!

chirontt commented Dec 1, 2024

Uh oh!

laeubi commented Dec 1, 2024

Uh oh!

Uh oh!

laeubi commented Aug 27, 2024 •

edited

Loading

github-actions bot commented Aug 27, 2024 •

edited

Loading

fredg02 commented Aug 28, 2024 •

edited

Loading

laeubi commented Aug 28, 2024 •

edited

Loading

akurtakov commented Nov 27, 2024 •

edited

Loading