Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Disable cpu asserts for JITServer #9837

Merged
merged 3 commits into from
Jun 12, 2020
Merged

Disable cpu asserts for JITServer #9837

merged 3 commits into from
Jun 12, 2020

Conversation

harryyu1994
Copy link
Contributor

@harryyu1994 harryyu1994 commented Jun 9, 2020 •
edited
Loading

Disabled the cpu related asserts for JITServer.
These asserts are meant to only test the correctness of new APIs
against old APIs for a single host processor and they fall apart
when we introduce remote target processors into the picture.

Issue: #9833

Signed-off-by: Harry Yu harryyu1994@gmail.com

@harryyu1994
Copy link
Contributor Author

@mpirvu Hi Marius, this one is ready for review

@harryyu1994 harryyu1994 marked this pull request as ready for review June 9, 2020 18:09
@mpirvu mpirvu added the comp:jitserver Artifacts related to JIT-as-a-Service project label Jun 9, 2020
@mpirvu mpirvu self-assigned this Jun 9, 2020
mpirvu
mpirvu approved these changes Jun 9, 2020
View reviewed changes
Copy link
Contributor

@mpirvu mpirvu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.
Doesn't this have to be done for P and Z too?

@mpirvu
Copy link
Contributor

mpirvu commented Jun 9, 2020

jenkins test sanity plinuxjit,xlinuxjit jdk11

@harryyu1994
Copy link
Contributor Author

Doesn't this have to be done for P and Z too?

Good point. I will add them in this PR as well.

@harryyu1994
Copy link
Contributor Author

Actually will only add Z as P changes aren't in yet.

@harryyu1994 harryyu1994 force-pushed the disableAssertsForJITServer branch 2 times, most recently from a56a1e8 to 8c3059e Compare June 9, 2020 19:14
@harryyu1994 harryyu1994 mentioned this pull request Jun 9, 2020
Closed
@harryyu1994 harryyu1994 requested a review from mpirvu June 9, 2020 19:25
@harryyu1994 harryyu1994 force-pushed the disableAssertsForJITServer branch 3 times, most recently from 9634270 to 1fd30dd Compare June 10, 2020 15:39
@harryyu1994 harryyu1994 requested a review from mpirvu June 10, 2020 15:41
@harryyu1994
Copy link
Contributor Author

@mpirvu Hi Marius, this one is ready for review & merge.

mpirvu
mpirvu reviewed Jun 10, 2020
View reviewed changes
Copy link
Contributor

@mpirvu mpirvu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just to confirm: CPU::is_test(OMRProcessorArchitecture p) and CPU::supports_feature_test(uint32_t feature) will be deleted in the end correct?
Everything else looks good.

@harryyu1994
Copy link
Contributor Author

harryyu1994 commented Jun 10, 2020 •
edited
Loading

Just to confirm: CPU::is_test(OMRProcessorArchitecture p) and CPU::supports_feature_test(uint32_t feature) will be deleted in the end correct?
Everything else looks good.

Yes they will be deleted. They are just here to alter/extend the behavior of OMRCPU's is_test() and supports_feature_test(). They will go away when OMRCPU's is_test() goes away.

(90% of things in J9CPU will be deleted in the end when OMRCPU is good enough to handle every platform, everything we put in J9CPU are customizations so unless they are OpenJ9 specific they will eventually live in OMRCPU)

@mpirvu
Copy link
Contributor

mpirvu commented Jun 10, 2020

jenkins test sanity plinuxjit,xlinuxjit jdk11

@harryyu1994
Copy link
Contributor Author

The only failure is rc016 from cmdLineTester_jvmtitests_debug_openj9_none_SCC_3. The crash does not look related to this change.

Testing: rc016
Test start time: 2020/06/10 23:17:35 Eastern Standard Time
Running command: "/home/jenkins/workspace/Test_openjdk11_j9_sanity.functional_x86-64_linux_jit_Personal_testList_1/openjdkbinary/j2sdk-image/bin/java" -XX:+UseJITServer -XX:+UseCompressedOops -Xgcpolicy:optthruput -Xdebug -Xrunjdwp:transport=dt_socket,address=8888,server=y,onthrow=no.pkg.foo,launch=echo -Xjit:count=0  -Xdump    -agentlib:jvmtitest=test:rc016 -cp /home/jenkins/workspace/Test_openjdk11_j9_sanity.functional_x86-64_linux_jit_Personal_testList_1/openjdk-tests/TKG/../../jvmtest/functional/cmdLineTests/jvmtitests/jvmtitest.jar:/home/jenkins/workspace/Test_openjdk11_j9_sanity.functional_x86-64_linux_jit_Personal_testList_1/openjdk-tests/TKG/../TKG/lib/asm-all.jar com.ibm.jvmti.tests.util.TestRunner
Time spent starting: 11 milliseconds
Time spent executing: 4764 milliseconds
Test result: FAILED
Output from test:
 [ERR] JITServer is currently a technology preview. Its use is not yet supported
 [ERR] JVMCDRT000E Unable to locate JIT stack map - aborting VM
 [ERR] JVMCDRT001E Method: java/lang/NullPointerException.<init>(Ljava/lang/String;)V (0000000000047DE8)
 [ERR] JVMCDRT002E Failing PC: 00007FF83CFDF223 (offset 0000000000000023), metaData = 00007FF81F9A52B8
 [ERR] 03:17:35.602 0x16700j9codertvm(j9ji.110    *   ** ASSERTION FAILED ** at jswalk.c:532: ((0 ))
 [ERR] JVMDUMP039I Processing dump event "traceassert", detail "" at 2020/06/10 23:17:35 - please wait.
 [ERR] JVMDUMP032I JVM requested System dump using '/home/jenkins/workspace/Test_openjdk11_j9_sanity.functional_x86-64_linux_jit_Personal_testList_1/openjdk-tests/TKG/test_output_15918429735834/cmdLineTester_jvmtitests_debug_openj9_none_SCC_3/core.20200610.231735.3005.0001.dmp' in response to an event
 [ERR] JVMDUMP010I System dump written to /home/jenkins/workspace/Test_openjdk11_j9_sanity.functional_x86-64_linux_jit_Personal_testList_1/openjdk-tests/TKG/test_output_15918429735834/cmdLineTester_jvmtitests_debug_openj9_none_SCC_3/core.20200610.231735.3005.0001.dmp
 [ERR] JVMDUMP032I JVM requested Java dump using '/home/jenkins/workspace/Test_openjdk11_j9_sanity.functional_x86-64_linux_jit_Personal_testList_1/openjdk-tests/TKG/test_output_15918429735834/cmdLineTester_jvmtitests_debug_openj9_none_SCC_3/javacore.20200610.231735.3005.0002.txt' in response to an event

@mpirvu
Copy link
Contributor

mpirvu commented Jun 11, 2020

jenkins test sanity xlinuxjit jdk11

@mpirvu
Copy link
Contributor

mpirvu commented Jun 11, 2020

I've triggered again the builds because this item needs to be double delivered in the 0.21 release and I wanted to be sure it's not going to cause problems.

@mpirvu
Copy link
Contributor

mpirvu commented Jun 11, 2020

@harryyu1994 This PR has conflicts that need to be resolved

@harryyu1994
Disable cpu asserts for JITServer
133082a 
Disabled the cpu related asserts for JITServer.
These asserts are meant to only test the correctness of new APIs
against old APIs for a single host processor and they fall apart
when we introduce remote target processors into the picture.

Signed-off-by: Harry Yu <harryyu1994@gmail.com>
@harryyu1994
Override cpu asserts in x86
3e6c00d 
The intention is to disable the cpu asserts for JITServer

Signed-off-by: Harry Yu <harryyu1994@gmail.com>
@harryyu1994
Override cpu asserts on Z
a061e2e 
The intention is to disable cpu assertion tests
for JITServer.

Signed-off-by: Harry Yu <harryyu1994@gmail.com>
mpirvu
mpirvu approved these changes Jun 11, 2020
View reviewed changes
Copy link
Contributor

@mpirvu mpirvu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mpirvu
Copy link
Contributor

mpirvu commented Jun 11, 2020

jenkins test sanity plinuxjit,xlinuxjit jdk11

@harryyu1994 harryyu1994 mentioned this pull request Jun 11, 2020
Merged
@mpirvu mpirvu merged commit 71bf160 into eclipse-openj9:master Jun 12, 2020
@harryyu1994 harryyu1994 deleted the disableAssertsForJITServer branch June 19, 2020 21:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mpirvu mpirvu mpirvu approved these changes

Assignees

@mpirvu mpirvu

Labels
comp:jitserver Artifacts related to JIT-as-a-Service project
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@harryyu1994 @mpirvu