Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable TOC for Remote Compilations #7958

Merged
merged 1 commit into from
Dec 10, 2019

Conversation

dchopra001
Copy link
Contributor

This commit disables the TOC in PPC for compiles done on the server because infrastructure to support TOC enabled code is currently not available in JITServer.

Signed-off-by: Dhruv Chopra Dhruv.C.Chopra@ibm.com

This commit disables the TOC in PPC for compiles
done on the server because infrastructure to support
TOC enabled code is currently not available in JITServer.

Signed-off-by: Dhruv Chopra <Dhruv.C.Chopra@ibm.com>
@dchopra001
Copy link
Contributor Author

@ymanton Can I get a review please?

@dchopra001
Copy link
Contributor Author

This PR depends on eclipse-omr/omr#4443.

Copy link
Member

@ymanton ymanton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@ymanton
Copy link
Member

ymanton commented Dec 5, 2019

Jenkins test sanity.functional all jdk8,jdk13 depends eclipse-omr/omr#4443

@ymanton
Copy link
Member

ymanton commented Dec 9, 2019

Jenkins test sanity.functional all jdk8 depends eclipse-omr/omr#4443

@ymanton
Copy link
Member

ymanton commented Dec 10, 2019

The jdk13 failures are infra related and were from a few days ago, the jdk8 builds I launched 6 hours ago all passed and the dependent change has reached openj9-omr so this is good to go.

@ymanton ymanton merged commit db1ce59 into eclipse-openj9:master Dec 10, 2019
@dchopra001 dchopra001 mentioned this pull request Dec 10, 2019
17 tasks
@dchopra001 dchopra001 deleted the disableTOCJITServer branch July 13, 2021 14:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
arch:power comp:jit depends:omr Pull request is dependent on a corresponding change in OMR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants