Replace MethodType & MethodTypeForm with OpenJDK implementation #7625
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fengxue-IS
force-pushed
the
replaceMT2
branch
from
c3c88c3
to
f1c711d
Compare
This was referenced Oct 29, 2019
babsingh
requested changes
Oct 29, 2019
fengxue-IS
force-pushed
the
replaceMT2
branch
2 times, most recently
from
cc2d5d6
to
81b12da
Compare
fengxue-IS
force-pushed
the
replaceMT2
branch
from
81b12da
to
e497f4d
Compare
Signed-off-by: Jack Lu <Jack.S.Lu@ibm.com>
fengxue-IS
changed the title
Signed-off-by: Jack Lu <Jack.S.Lu@ibm.com>
Signed-off-by: Jack Lu <Jack.S.Lu@ibm.com>
- MT.returnType -> MT.returnType() - MT.arguments -> MT.ptypes() - MT.argSlots -> MT.parameterSlotCount() - MT.dropFirstParameterType -> MT.dropParameterTypes(0,1) - MT.getInvokeExactHandle() -> MT.invokers().exactInvoker() Signed-off-by: Jack Lu <Jack.S.Lu@ibm.com>
Signed-off-by: Jack Lu <Jack.S.Lu@ibm.com>
Signed-off-by: Jack Lu <Jack.S.Lu@ibm.com>
Name changes: - MT.arguments -> MT.ptypes - MT.returnType -> MT.rtype - MT.vmResolveFromMethodDescriptorString -> MTHelper.vmResolveFromMethodDescriptorString New refs: - MethodTypeHelper.class - MethodTypeForm.class - MethodType.form - MethodTypeForm.argCounts Removed: - MethodType.stackDescriptionBits - MethodType.argSlots Replaced with parameterSlotCount() API Signed-off-by: Jack Lu <Jack.S.Lu@ibm.com>
- Update field name to OpenJDK name - Remove METHODTYPE_STACKDESCRIPTIONBITS - Add VMHelpers::getArgSlotFromMethodType API to replaces J9VMJAVALANGINVOKEMETHODTYPE_ARGSLOTS marco Signed-off-by: Jack Lu <Jack.S.Lu@ibm.com>
- generate stackbits using MT.ptypes Signed-off-by: Jack Lu <Jack.S.Lu@ibm.com>
Signed-off-by: Jack Lu <Jack.S.Lu@ibm.com>
|
@fengxue-IS @babsingh is this still relevant? |
yes, we are planning to merge these changes in a partially inactive state. #10096 depends on this PR. |
|
Note there are merge conflicts. |
|
Closing this PR as it is no longer relevent |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Depends: #7628 #8066
Part of: #7352
Signed-off-by: Jack Lu Jack.S.Lu@ibm.com