Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable ArrayTranslateAndTest support on Z for remote compilations #6925

Merged
merged 1 commit into from
Sep 17, 2019

Conversation

dchopra001
Copy link
Contributor

Signed-off-by: Dhruv Chopra Dhruv.C.Chopra@ibm.com

Signed-off-by: Dhruv Chopra <Dhruv.C.Chopra@ibm.com>
@dchopra001 dchopra001 mentioned this pull request Aug 30, 2019
32 tasks
@fjeremic fjeremic added arch:z comp:jitserver Artifacts related to JIT-as-a-Service project labels Sep 4, 2019
@fjeremic fjeremic self-assigned this Sep 4, 2019
@fjeremic
Copy link
Contributor

fjeremic commented Sep 4, 2019

@dchopra001 can you put some details here for future reference as to what problem you encountered which warranted disabling this? Looking at Idiom Recognition I also see many other related queries [1]. Do we need to disable all of these under JITServer? I would assume all of them would require some kind of table which I assume is the thing we couldn't relocate. Some details would be helpful to identify if this is the case.

[1] https://github.com/eclipse/openj9/blob/ec5d412fb412107af9b187cc1660d3d05d8b2df6/runtime/compiler/optimizer/IdiomRecognition.cpp#L1036-L1042

@dchopra001
Copy link
Contributor Author

dchopra001 commented Sep 17, 2019

@fjeremic The problem on Z, as you mentioned in your comment, is that we are generating instructions like TROT that cannot be relocated currently.

Ex in the arrayTranslateEvaluator on Z: https://github.com/eclipse/omr/blob/1b7d7ab032b622b79b7d2372a13d90a770de78fb/compiler/z/codegen/OMRTreeEvaluator.cpp#L10750-L10771

See #6926 for a similar PR that disables some of the other queries on Z. (In hindsight I should have grouped these two PRs together).

Looking at Idiom Recognition I also see many other related queries [1]. Do we need to disable all of these under JITServer?

Some of the queries you've listed in your comment are only used on X and Power. So we don't need to disable all of them. I saw at least one such query on X which would eventually map to a loop in PicBuilder code that would perform the translation. So I don't think x86 is generating these tables that need relocations. I can't comment on Power yet. However if they are then we will need to disable those as well.

@fjeremic
Copy link
Contributor

This is going into the jitaas branch so testing is not needed and the change is contained. I'm comfortable merging this obvious fix.

@fjeremic fjeremic merged commit ba846d3 into eclipse-openj9:jitaas Sep 17, 2019
@dchopra001 dchopra001 deleted the arrayTranslate branch July 13, 2021 13:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
arch:z comp:jitserver Artifacts related to JIT-as-a-Service project
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants