Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

WIP: AArch64: J9MemoryReference changes for loadaddrEvaluator() #6550

Closed
wants to merge 1 commit into from
Closed

WIP: AArch64: J9MemoryReference changes for loadaddrEvaluator() #6550

wants to merge 1 commit into from

Conversation

knn-k
Copy link
Contributor

@knn-k knn-k commented Jul 23, 2019

This commit makes changes to J9MemoryReference for AArch64.
They are required by loadaddrEvaluator() with unresolved snippet.

Signed-off-by: KONNO Kazuhiro konno@jp.ibm.com

@knn-k knn-k mentioned this pull request Jul 23, 2019
Merged
@knn-k
Copy link
Contributor Author

knn-k commented Jul 23, 2019

This depends on eclipse-omr/omr#4122.

@0xdaryl 0xdaryl self-assigned this Jul 25, 2019
@knn-k knn-k mentioned this pull request Sep 18, 2019
Merged
@knn-k
AArch64: J9MemoryReference changes for loadaddrEvaluator()
f99702a 
This commit makes changes to J9MemoryReference for AArch64.
They are required by loadaddrEvaluator() with unresolved snippet.

Signed-off-by: KONNO Kazuhiro <konno@jp.ibm.com>
@knn-k
Copy link
Contributor Author

knn-k commented Sep 26, 2019

J9::ARM64::MemoryReference::generateBinaryEncoding() assumes using x9 as the dedicated register for unresolved data snippet. That approach needs to be changed along with #5985.
Unresolved data snippet is currently disabled.

@knn-k
Copy link
Contributor Author

knn-k commented Oct 7, 2019

Cancelling this PR.
I will implement the necessary code along with UnresolvedDataSnippet.

@knn-k knn-k closed this Oct 7, 2019
@knn-k knn-k deleted the aarch64codegen21 branch June 24, 2020 11:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@0xdaryl 0xdaryl

Labels
arch:aarch64 comp:jit
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@knn-k @0xdaryl