Add MSVS 2017 support for JDK11 and next to Windows platform #2792
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- enable VS2017 as toolchain for JDK11 - add MinGW to PATH [ci skip] Signed-off-by: Violeta Sebe <vsebe@ca.ibm.com>
|
Blocked by eclipse-omr/omr#2885 |
|
eclipse-omr/omr#2885 has been closed. |
I believe so, its supposed to work now. |
|
Windows build passed. |
vsebe
changed the title
|
Jenkins test sanity win jdk11 |
|
@pshipton please review, thank you! |
|
jenkins test extended win jdk11 |
|
The failures in the builds are expected and don't appear to be caused by the compiler change. |
pshipton
approved these changes
Sep 14, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[ci skip]
The build environments table in the doc needs to be updated
https://www.eclipse.org/openj9/docs/openj9_support/#openjdk-10_1
eclipse-openj9/openj9-docs#72 (comment)
Signed-off-by: Violeta Sebe vsebe@ca.ibm.com