(0.57) Notify unblocker during OMR wait #23116
Draft
+30
−18
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There are currently two paths where the unblocker may spin in a tight loop. The first is if the continuation list is empty and the second is if a virtualThread is waiting on a lock owned by a platform thread. Both of these cases are handled by this PR. The first case is handled by removing the `(NULL == vm->blockedContinuations)` check at the start of the function. The second case is handled by removing the hasPlatformThreadWaiting code and instead notifying the unblocker anytime a platform thread waits on a monitor. Signed-off-by: Tobi Ajila <atobia@ca.ibm.com>
Member
|
#23117 needs to be added to this. |
Add macros to protect JDK24+ code. Signed-off-by: Tobi Ajila <atobia@ca.ibm.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There are currently two paths where the unblocker may spin in a tight loop. The first is if the continuation list is empty and the second is if a virtualThread is waiting on a lock owned by a platform thread. Both of these cases are handled by this PR.
The first case is handled by removing the
(NULL == vm->blockedContinuations)check at the start of the function. The second case is handled by removing the hasPlatformThreadWaiting code and instead notifying the unblocker anytime a platform thread waits on a monitor.Backport of #22358 and #23116
Fixes ibmruntimes/Semeru-Runtimes#117