Add trace points to inline cast check #23114
Open
+2
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
I may be wrong, but I think new tracepoints have to be added at the end of the file. @pshipton could you confirm? |
Member
|
That is correct, we don't want to change existing tracepoint numbers. |
mpirvu
reviewed
Dec 18, 2025
KavinSatheeskumar
force-pushed
the
trace_inline_cast_check
branch
from
33f5a24 to
02e3376
Compare
mpirvu
requested changes
Dec 19, 2025
KavinSatheeskumar
force-pushed
the
trace_inline_cast_check
branch
from
02e3376 to
45bdf7a
Compare
mpirvu
reviewed
Dec 20, 2025
This PR adds a trace point to the method which calls inlineCheckCast to attempt to diagnose this issue eclipse-openj9#23057
KavinSatheeskumar
force-pushed
the
trace_inline_cast_check
branch
from
45bdf7a to
4a5b3fb
Compare
mpirvu
reviewed
Dec 23, 2025
Contributor
mpirvu
left a comment
mpirvu
left a comment
There was a problem hiding this comment.
LGTM. I will wait for confirmation from local tests that the trace message appears in the Snap files.
mpirvu
approved these changes
Dec 23, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a trace point to attempt to diagnose this issue #23057
This segmentation fault appears very infrequently, so we add break points to attempt to gleam more information the next time it arises in the tests.
From the stack trace, we have narrowed down the issue to the method
instanceOfOrCheckCastNoCacheUpdate. So we add the break point as required.