Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add spec file for Valhalla Nestmates build #2086

Closed
wants to merge 2 commits into from
Closed

Add spec file for Valhalla Nestmates build #2086

wants to merge 2 commits into from

Conversation

fengxue-IS
Copy link
Contributor

@fengxue-IS fengxue-IS commented Jun 5, 2018 •
edited
Loading

[ci skip]

Signed-off-by: Jack Lu Jack.S.Lu@ibm.com

@fengxue-IS fengxue-IS changed the title WIP: Add spec file for Valhalla Nestmates build Add spec file for Valhalla Nestmates build Jun 6, 2018
@fengxue-IS
Copy link
Contributor Author

@tajila can you take a look

@tajila
Copy link
Contributor

tajila commented Jun 6, 2018

lgtm @pshipton can you please review

pshipton
pshipton reviewed Jun 6, 2018
View reviewed changes
buildspecs/linux_x86-64_cmprssptrs_valhalla_nestmates.spec Outdated
-->

<spec xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance" xmlns="http://www.ibm.com/j9/builder/spec" xsi:schemaLocation="http://www.ibm.com/j9/builder/spec spec-v1.xsd" id="linux_x86-64_cmprssptrs_valhalla_nestmates">
<name>Linux Hammer Compressed Pointers</name>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add Valhalla to the name.

buildspecs/linux_x86-64_cmprssptrs_valhalla_nestmates.spec
<flag id="graph_cmdLineTester" value="true"/>
<flag id="graph_compile" value="true"/>
<flag id="graph_enableModularityTesting" value="true"/>
<flag id="graph_enableTesting" value="true"/>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The panama spec has enableTesting and enableTesting_Java8 set to false, although not sure if it matters with all the build parameters set to false.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The flag part was set based off the current linux_ppc-64_cmprssptrs_le_valhalla_nestmates.spec, not sure if the enableTesting flag actually matter in OpenJ9 builds as this will not be run under Java8,9 (ie Axxon)
I updated enableTesting_Java8 to false to make it look more consistent

@pshipton
Copy link
Member

pshipton commented Jun 6, 2018

Note you can add [ci skip] to your commit to avoid the unnecessary travis build.

@fengxue-IS fengxue-IS changed the title Add spec file for Valhalla Nestmates build [ci skip]Add xLinux spec file for Valhalla Nestmates build Jun 7, 2018
@fengxue-IS
Copy link
Contributor Author

Added Valhalla Nestmates to the name, updated title to skip travis-ci, fixed Java8 testing flag

@fengxue-IS fengxue-IS changed the title [ci skip]Add xLinux spec file for Valhalla Nestmates build Add xLinux spec file for Valhalla Nestmates build Jun 7, 2018
@fengxue-IS
Copy link
Contributor Author

as per discussion in ibmruntimes/openj9-openjdk-jdk10#39, I ll also be updating the existing ppc le valhalla spec to use gcc for OpenJ9

@fengxue-IS fengxue-IS changed the title Add xLinux spec file for Valhalla Nestmates build WIP Add xLinux spec file for Valhalla Nestmates build Jun 7, 2018
@fengxue-IS fengxue-IS changed the title WIP Add xLinux spec file for Valhalla Nestmates build Add xLinux spec file for Valhalla Nestmates build Jun 7, 2018
@fengxue-IS
Copy link
Contributor Author

I have added a new spec for ppc-le-gcc, the old ppc spec can be deleted in another PR if it not be used any more in the future
@tajila can you take a look at the new ppc spec? thanks

@fengxue-IS fengxue-IS changed the title Add xLinux spec file for Valhalla Nestmates build Add spec file for Valhalla Nestmates build Jun 7, 2018
AdamBrousseau
AdamBrousseau reviewed Jun 8, 2018
View reviewed changes
Copy link
Contributor

@AdamBrousseau AdamBrousseau left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If you're adding plinux_gcc for nestmates should we also remove the non-gcc nestmates spec? Sorry, just saw your comment. Is there anything stopping us from removing the old one in the same PR?

@fengxue-IS
Copy link
Contributor Author

@AdamBrousseau I am not sure the original purpose of adding the ppc build spec, will leave that for @tajila to decide as he supervised Talia's work

@AdamBrousseau
Copy link
Contributor

I think originally nestmates was added to the xlc version by accident.

@fengxue-IS
Copy link
Contributor Author

ok, I'll remove the old spec and ask for another round of review

@fengxue-IS
Add xLinux spec file for Valhalla Nestmates build
14c12b9 
[ci skip]

Signed-off-by: Jack Lu <Jack.S.Lu@ibm.com>
@fengxue-IS
Add pLinux GCC build spec file for Valhalla Nestmates
4c4a880 
- replaced the old xlC spec with gcc for pLinux build

[ci skip]

Signed-off-by: Jack Lu <Jack.S.Lu@ibm.com>
@AdamBrousseau
Copy link
Contributor

Is this obsolete due to #2270 ?

@tajila
Copy link
Contributor

tajila commented Jul 6, 2018

@AdamBrousseau yes

@pshipton pshipton closed this Jul 11, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pshipton pshipton pshipton left review comments

@AdamBrousseau AdamBrousseau AdamBrousseau left review comments

Assignees
No one assigned
Labels
comp:build
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@fengxue-IS @tajila @pshipton @AdamBrousseau