Update disabled functional/Valhalla tests #20479
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add CheckedType issue eclipse-openj9#19764 comment to resolve disabled test. This test was not associated with any issues previously. Signed-off-by: Theresa Mammarella <Theresa.T.Mammarella@ibm.com>
Signed-off-by: Theresa Mammarella <Theresa.T.Mammarella@ibm.com>
theresa-m
force-pushed
the
disabled_valhalla_tests_2
branch
from
7187edc
to
9c5f947
Compare
hangshao0
reviewed
Nov 1, 2024
test/functional/Valhalla/src_qtypes/org/openj9/test/lworld/ValueTypeTests.java
Show resolved
Hide resolved
theresa-m
force-pushed
the
disabled_valhalla_tests_2
branch
from
9c5f947
to
294d74f
Compare
theresa-m
changed the title
Since the time this tests was disabled it has become illegal to use synchronized methods that are not static. This is tested in testValueTypeHasSynchMethods. This change removes the part of testSynchMethodsOnValueTypes that attempts to verify a synchronized instance method and renames the test to testStaticSynchMethodsOnValueTypes. Signed-off-by: Theresa Mammarella <Theresa.T.Mammarella@ibm.com>
These tests cannot be expressed without an lw5 level javac. These will be enabled when tests are migrated to the src_lw5 versions which is related to eclipse-openj9#20268. Signed-off-by: Theresa Mammarella <Theresa.T.Mammarella@ibm.com>
theresa-m
force-pushed
the
disabled_valhalla_tests_2
branch
from
294d74f
to
6f8abd9
Compare
|
Jenkins test sanity.functional,extended alinuxval jdknext |
1 similar comment
|
Jenkins test sanity.functional,extended alinuxval jdknext |
hangshao0
approved these changes
Nov 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change along with #20473 enables all the disabled tests in ValueTypeTests or associates them with an issue. The change includes: