-
Notifications
You must be signed in to change notification settings - Fork 720
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for structs in FFI Upcall on z/OS #19937
Conversation
5c43fb0
to
6fd35b7
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have started review, before I continue reviewing the rest of the changes posting what I found while skimming through.
Please update the PR with proper commit message explaining what this change is doing with signoff.
6fd35b7
to
f680ff4
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think overall looks good to me, one last nitpick.
3de4214
to
8d86148
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Two minor nits.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
c83b251
to
7eafb57
Compare
@r30shah Commits are squashed, so we can run tests now. |
Jenkins test sanity zlinux jdk21 |
This commit completes FFI Upcall functionality support on z/OS by adding support to handle structs as parameters and return types. Signed-off-by: Dhruv Chopra <Dhruv.C.Chopra@ibm.com>
7eafb57
to
2845176
Compare
Jenkins test sanity zlinux jdk21 |
I have launched internal build for IBM Java 8 and also build for z/OS, Will merge this change once this builds on the PR and the one I launched internally finishes. |
Merging this as JDK21 on Linux on Z test passes (Which will execute some of the changes from this PR through upcall tests) and I see Build job finishes on z/OS. |
This PR primarily completes the FFI Upcall feature on z/OS by adding support to handle struct arguments and return types on z/OS. In addition, it adds formatting changes and enabled the FFI Upcall functionality on z/OS.